Skip to content

Use java.lang.Objects#equals; eliminate a couple of nulls#307

Merged
garydgregory merged 1 commit intoapache:masterfrom
stevebosman-oc:objects-equals
Jun 6, 2022
Merged

Use java.lang.Objects#equals; eliminate a couple of nulls#307
garydgregory merged 1 commit intoapache:masterfrom
stevebosman-oc:objects-equals

Conversation

@stevebosman-oc
Copy link
Contributor

Contributed on behalf of the @opencastsoftware open source team

@codecov-commenter
Copy link

Codecov Report

Merging #307 (51eb7f7) into master (1677dac) will increase coverage by 0.08%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master     #307      +/-   ##
============================================
+ Coverage     85.87%   85.95%   +0.08%     
+ Complexity     4676     4670       -6     
============================================
  Files           292      292              
  Lines         13469    13467       -2     
  Branches       1955     1954       -1     
============================================
+ Hits          11566    11576      +10     
+ Misses         1326     1325       -1     
+ Partials        577      566      -11     
Impacted Files Coverage Δ
...mons/collections4/comparators/ComparatorChain.java 65.33% <0.00%> (ø)
...ommons/collections4/multiset/AbstractMultiSet.java 43.47% <0.00%> (+0.31%) ⬆️
.../org/apache/commons/collections4/map/Flat3Map.java 72.76% <33.33%> (+0.19%) ⬆️
...llections4/comparators/TransformingComparator.java 86.36% <50.00%> (+4.54%) ⬆️
...g/apache/commons/collections4/CollectionUtils.java 94.34% <100.00%> (+0.21%) ⬆️
...ava/org/apache/commons/collections4/ListUtils.java 87.30% <100.00%> (+0.68%) ⬆️
.../commons/collections4/functors/DefaultEquator.java 60.00% <100.00%> (+20.00%) ⬆️
...ache/commons/collections4/map/StaticBucketMap.java 93.66% <100.00%> (+2.71%) ⬆️
...commons/collections4/trie/AbstractBitwiseTrie.java 76.92% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1677dac...51eb7f7. Read the comment docs.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@garydgregory garydgregory merged commit e85e26e into apache:master Jun 6, 2022
@garydgregory garydgregory changed the title When possible use java.lang.Objects#equals; eliminated a couple of nulls Use java.lang.Objects#equals; eliminated a couple of nulls Jun 6, 2022
@garydgregory garydgregory changed the title Use java.lang.Objects#equals; eliminated a couple of nulls Use java.lang.Objects#equals; eliminate a couple of nulls Jun 6, 2022
anantdamle pushed a commit to anantdamle/commons-collections that referenced this pull request Aug 14, 2023
anantdamle pushed a commit to anantdamle/commons-collections that referenced this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants