Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apache/commons-csv
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4434d93
Choose a base ref
...
head repository: aeschwabe/commons-csv
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 119fdb6
Choose a head ref
  • 3 commits
  • 0 files changed
  • 1 contributor

Commits on May 19, 2018

  1. Configuration menu
    Copy the full SHA
    ddcf2cf View commit details
    Browse the repository at this point in the history
  2. [CSV-225] Test case updates.

    CSVParserTest:
     - Add basic parser test for all parse/constructor variants.
     - Add parser test for null Path.
     - Fix parser test for null URL that was cast to File.
     - Fix parset test for null File/format so it does not pass an illegal file name and trigger a FileNotFoundException (only prevented by the sequence of arg validation).
     - Convert all arg validating tests to use try resource blocks.
    
    PerformanceTest:
     - Fix perf test so that it doesn't look for the input file in the java.io.tmpdir but instead as a relative path.
     - Add basic parse timings for other constructor variants using Path and URL.
     - Avoid creating a redundant BufferedReader in basic parser test.
     - Use printf.
    aeschwabe committed May 19, 2018
    Configuration menu
    Copy the full SHA
    cdb9618 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2019

  1. Configuration menu
    Copy the full SHA
    119fdb6 View commit details
    Browse the repository at this point in the history
Loading