Skip to content

[CSV-267] Minor improvements#126

Merged
garydgregory merged 1 commit into
apache:masterfrom
arturobernalg:feature/CSV-267
Dec 12, 2020
Merged

[CSV-267] Minor improvements#126
garydgregory merged 1 commit into
apache:masterfrom
arturobernalg:feature/CSV-267

Conversation

@arturobernalg

@arturobernalg arturobernalg commented Dec 12, 2020

Copy link
Copy Markdown
Member

Minor improvement

  • extra computations by getting the string size only once.
  • remove unused imports
  • add final String
  • add final method and var
  • fix javaDoc

https://issues.apache.org/jira/browse/CSV-267

@coveralls

coveralls commented Dec 12, 2020

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.002%) to 98.455% when pulling 5c7a6f2 on arturobernalg:feature/CSV-267 into e5fbba3 on apache:master.

@garydgregory

Copy link
Copy Markdown
Member

@arturobernalg
Please rebase on master.
TY!
Gary

@arturobernalg

Copy link
Copy Markdown
Member Author

done

@garydgregory garydgregory merged commit 64bae17 into apache:master Dec 12, 2020
@garydgregory garydgregory changed the title [CSV-267] - Minor improvement [CSV-267] - Minor improvements Dec 12, 2020
asfgit pushed a commit that referenced this pull request Dec 12, 2020
@garydgregory garydgregory changed the title [CSV-267] - Minor improvements [CSV-267] Minor improvements Dec 12, 2020
asfgit pushed a commit that referenced this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants