Skip to content

CSV-203: withNullString value is printed without quotes when QuoteMod…#17

Closed
kparoth wants to merge 4 commits into
apache:masterfrom
kparoth:CSV-203
Closed

CSV-203: withNullString value is printed without quotes when QuoteMod…#17
kparoth wants to merge 4 commits into
apache:masterfrom
kparoth:CSV-203

Conversation

@kparoth

@kparoth kparoth commented Mar 19, 2017

Copy link
Copy Markdown

…e.ALL is specified

In my opinion this is only a small change. If I already set the option (QuoteMode.ALL), then it should also be used.

JIRA-Reference

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.2%) to 93.266% when pulling e295ac3 on kparoth:CSV-203 into a775784 on apache:master.

@coveralls

coveralls commented Mar 19, 2017

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 93.09% when pulling e295ac3 on kparoth:CSV-203 into a775784 on apache:master.

@garydgregory

Copy link
Copy Markdown
Member

But then you cannot do a round trip. How would you differentiate a null value from a string with the same representation?

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.2%) to 93.266% when pulling 82b5210 on kparoth:CSV-203 into a775784 on apache:master.

@kparoth

kparoth commented Mar 22, 2017

Copy link
Copy Markdown
Author

The programmer should select a value that is unique and does not correspond to one of the possible values. But "N/A" is already quite clear.

But the fact is, if I have set the mode to ALL, then my default for "withNullString" should be formatted as well.

But it is also just a suggestion. ;-)

@garydgregory

Copy link
Copy Markdown
Member

For backward compatibility, maybe we need to add a QUOTE_ALL_NON_NULL

@coveralls

coveralls commented Mar 27, 2017

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.04%) to 93.099% when pulling aebe0d0 on kparoth:CSV-203 into a775784 on apache:master.

asfgit pushed a commit that referenced this pull request Mar 27, 2017
withNullString value is printed without quotes when QuoteMode.ALL is
specified; add QuoteMode.ALL_NON_NULL. PR #17.
asfgit pushed a commit that referenced this pull request Mar 27, 2017
withNullString value is printed without quotes when QuoteMode.ALL is
specified; add QuoteMode.ALL_NON_NULL. PR #17.
asfgit pushed a commit that referenced this pull request Mar 27, 2017
withNullString value is printed without quotes when QuoteMode.ALL is
specified; add QuoteMode.ALL_NON_NULL. PR #17.
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 93.373% when pulling 3ddc583 on kparoth:CSV-203 into 74afb17 on apache:master.

2 similar comments
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 93.373% when pulling 3ddc583 on kparoth:CSV-203 into 74afb17 on apache:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 93.373% when pulling 3ddc583 on kparoth:CSV-203 into 74afb17 on apache:master.

@garydgregory

garydgregory commented Jul 8, 2021

Copy link
Copy Markdown
Member

Closing, see git master.

garydgregory pushed a commit that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants