CSV-203: withNullString value is printed without quotes when QuoteMod…#17
Closed
kparoth wants to merge 4 commits into
Closed
CSV-203: withNullString value is printed without quotes when QuoteMod…#17kparoth wants to merge 4 commits into
kparoth wants to merge 4 commits into
Conversation
…e.ALL is specified
Member
|
But then you cannot do a round trip. How would you differentiate a null value from a string with the same representation? |
Author
|
The programmer should select a value that is unique and does not correspond to one of the possible values. But "N/A" is already quite clear. But the fact is, if I have set the mode to ALL, then my default for "withNullString" should be formatted as well. But it is also just a suggestion. ;-) |
Member
|
For backward compatibility, maybe we need to add a QUOTE_ALL_NON_NULL |
asfgit
pushed a commit
that referenced
this pull request
Mar 27, 2017
asfgit
pushed a commit
that referenced
this pull request
Mar 27, 2017
asfgit
pushed a commit
that referenced
this pull request
Mar 27, 2017
2 similar comments
Member
|
Closing, see git master. |
garydgregory
pushed a commit
that referenced
this pull request
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e.ALL is specified
In my opinion this is only a small change. If I already set the option (QuoteMode.ALL), then it should also be used.
JIRA-Reference