PROPOSAL: Lines containing whitespace only should not generate empty records#18
Closed
attil-io wants to merge 4 commits into
Closed
PROPOSAL: Lines containing whitespace only should not generate empty records#18attil-io wants to merge 4 commits into
attil-io wants to merge 4 commits into
Conversation
1 similar comment
Member
|
Closing this PR as we have the following:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the following settings, I would expect that any line containing white space only, does NOT generate an additional empty record:
IgnoreEmpty=true IgnoreSpaces=trueReason is, that since white spaces (like tab, space) are ignored, then white-space-only line should count as empty lines (and empty lines are ignored too).
Please tell me if you agree with the idea or not (if you do, I will be happy to do all the necessary steps, like creating JIRA account, opening ticket, signing the CLA, etc.)
I'm also aware, that maybe my code change is not the best solution for the problem (e.g. now ignoreWhiteSpaces is checked twice in
Lexer.nextToken()), so please treat this PR rather as a POC, and not the final solution. I would be happy to rework it, if you have any suggestions/comments.