CSV-292: Add Automatic-Module-Name to JAR file#191
Conversation
kinow
left a comment
There was a problem hiding this comment.
Conflicts in the pom.xml file. But looks good to me other than that.
|
@kinow I'm a little confused as to why there's a conflict. Files Changed view shows a clean additive diff so not sure why GitHub seems to think the entire file is conflicted I will try a rebase tomorrow and see if that cleans things up |
|
@rvesse I took the liberty to rebase and push to your branch, hope that's OK. Take a look to confirm your change is still OK, please. The conflicts were created in the post-release commits to |
This allows for using Commons CSV in JPMS based projects that want to declare a requirement on the org.apache.commons.csv module
|
@kinow What needs to happen for this to get merged? |

Ensure that the resulting Commons CSV JAR file can be used in JPMS based
projects
Prior to this change the JAR is missing the
Automatic-Module-Nameentry in itsmanifest meaning it cannot be used in JPMS based projects (e.g. rvesse/airline#106) yielding errors like the following:
With this change JPMS based projects can successfully use Commons CSV without errors.