CSV-288 Fix for multi-char delimiter not working as expected#218
Merged
Conversation
When checking if previous token is delimiter, isDelimiter(lastChar) unintentionally advance the buffer pointer. Also isDelimiter(lastChar) cannot handle multi-char delimiter. To fix this, create a new indicator isLastTokenDelimiter instead of using isDelimiter(lastChar), the indicator is set/reset in isDelimiter()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue: https://issues.apache.org/jira/browse/CSV-288
When checking if last token is delimiter in below line of code
isDelimiter(lastChar)unintentionally advance the buffer pointer and consume the first"|"when it comes to the"b"in"a||b||c"(lastChar is"|", nextChar is also"|", make it"||"). Subsequent read will see"|c"instead of"||c"so the second token is"b|c"In addition,
isDelimiter(lastChar)cannot handle multi-char delimiter.To fix this, create a new indicator
isLastTokenDelimiterinstead of usingisDelimiter(lastChar), the indicator is set/reset inisDelimiter()