CSVParser: Identify duplicates in null, empty and blank header names#279
Merged
garydgregory merged 1 commit intoOct 26, 2022
Merged
Conversation
Duplicate missing header names are handled consistently between CSVFormat and CSVParser. Document that the ignore header case flag is for parser behaviour. Update CSVDuplicateHeaderTest to add the ignore header case flag to tests. Add test cases with case insensitive duplicates.
73f06e5 to
69aa686
Compare
garydgregory
added a commit
that referenced
this pull request
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the CSVParser to throw on a duplicate null header name when using DuplicateHeaderMode.DISALLOW. This matches the behaviour of CSVFormat.