[CSV-306] replace deprecated method in user guide, update external link#324
Conversation
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
=========================================
Coverage 97.87% 97.87%
Complexity 549 549
=========================================
Files 11 11
Lines 1178 1178
Branches 204 204
=========================================
Hits 1153 1153
Misses 13 13
Partials 12 12 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| <p>Other CSV implementations: </p> | ||
| <ul> | ||
| <li><a href="http://supercsv.sourceforge.net/">Super CSV</a></li> | ||
| <li><a href="https://super-csv.github.io/super-csv/index.html">Super CSV</a></li> |
There was a problem hiding this comment.
👍 checked the sourceforge page, and it's redirecting to this github.io one.
kinow
left a comment
There was a problem hiding this comment.
@samabcde I was going to merge and close CSV-306, but I think this PR does not fix CSV-306?
I imported this branch into my IDE, and looked at src/site/xdoc/user-guide.xml, and looking at the example code I started searching for methods and opening to check for @deprecated tags.
This line is also using withHeader()
final CSVParser parser = new CSVParser(reader, CSVFormat.EXCEL.withHeader());
marked as deprecated
* @deprecated Use {@link Builder#setHeader(Class)}
Further down there's another one
Iterable<CSVRecord> records = CSVFormat.RFC4180.withHeader("ID", "CustomerNo", "Name").parse(in);
I can merge this one and leave the JIRA issue open. Or if you'd like this PR to resolve CSV-306, could you look at the rest of the user guide fixing deprecated calls? Up to you 🙂
Cheers
Bruno
|
Oh, and thanks for fixing the links and typos! |
@kinow , thx for pointing out, let me fix that also. |
In addition, I found some dead link in https://commons.apache.org/proper/commons-csv/ like
Genjava CSV
Informix UNLOAD
Informix UNLOAD CSV