[CSV-238] Escape quotes in CLOBs#39
Closed
luyseyal wants to merge 1 commit into
Closed
Conversation
Author
Author
|
@britter Can you review this? Gary's code in master does fix the general idea behind outputting CLOBs but it doesn't escape quotes embedded in the CLOB string. This patch enables escaping the quotes so that Excel output will work (and probably others). |
381b4a9 to
ed49199
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(The bad coveralls report is from code merged to master this last weekend, not this patch)
This fixes Excel output by enabling the escaping of quotes in CLOBs.
Given a CLOB like:
The patch will transform it to: