Skip to content

Post release fixes #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garydgregory merged 12 commits into from
Jun 15, 2019
Merged

Post release fixes #44

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
dd0bb04
Fix checkstyle: remove tabs
aherbert Jun 13, 2019
d73e344
Fix checkstyle: Split long line
aherbert Jun 13, 2019
aaef154
Fix checkstyle: exclude pom.properties
aherbert Jun 13, 2019
084333f
Update findbugs to allow deliberate fall-through
aherbert Jun 13, 2019
74ce045
Fix pmd: Remove ternary operator returning false
aherbert Jun 13, 2019
4a9a91e
Fix pmd: Remove implicit final
aherbert Jun 13, 2019
db610b3
Fix pmd: Ignore TooManyStaticImports.
aherbert Jun 13, 2019
69a9b7d
Add tests to cover use of the IOUtils class.
aherbert Jun 13, 2019
53b8e39
Clean-up findbugs exclude filter.
aherbert Jun 13, 2019
5472126
Removed unused import
aherbert Jun 13, 2019
9108a3b
Updated test comments for print tests targeting IOUtils.
aherbert Jun 14, 2019
e9e98f0
Fix checkstyle: Suppress line length warning in CSVParser.
aherbert Jun 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix checkstyle: exclude pom.properties
  • Loading branch information
@aherbert
aherbert committed Jun 15, 2019
commit aaef15424be22564f213d3634e793c118b296f0b
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ CSV files of various types.

<checkstyle.version>3.0.0</checkstyle.version>
<checkstyle.header.file>${basedir}/LICENSE-header.txt</checkstyle.header.file>
<checkstyle.resourceExcludes>LICENSE.txt, NOTICE.txt</checkstyle.resourceExcludes>
<checkstyle.resourceExcludes>LICENSE.txt, NOTICE.txt, **/maven-archiver/pom.properties</checkstyle.resourceExcludes>

@garydgregory garydgregory Jun 14, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be in commons-parent?

@aherbert aherbert Jun 14, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICS there is no checkstyle configuration in commons-parent, or PMD. I thought it was just up to projects to configure as appropriate. Using the maven plugin property checkstyle.resourceExcludes is not done on other commons projects I know. These use a <configuration> section and <resourceExcludes> tag. There is more than one way to skin a cat.

Are you suggesting to add profiles like those for other optional plugins such as jacoco? Each project is of a different age and coding style. So a standard checkstyle probably would not work as is and a transition period to a common style would be needed. A common style would certainly make browsing source from different projects easier. I'd say the discussion on this is outside the scope of this PR.

@garydgregory garydgregory Jun 14, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outside the scope of this PR

Agreed.


<japicmp.skip>false</japicmp.skip>

Expand Down