Fix CSV-149 and CSV-195#60
Merged
Merged
Conversation
sgoeschl
reviewed
Feb 25, 2020
Contributor
Author
|
@sgoeschl @garydgregory thanks very much for code review suggestions. |
|
LGTM |
Member
|
I will review tonight... |
garydgregory
requested changes
Mar 26, 2020
5f624fd to
8014c0e
Compare
Contributor
Author
|
@garydgregory thanks. I have updated the pr to resolve conflicts and reviews |
Member
|
@dota17 |
Contributor
Author
|
@garydgregory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix [CSV-195] and [CSV-149]
when stream end with normal char but not lineseparator will add 1 to currentlinenumber.
https://issues.apache.org/jira/browse/CSV-149
https://issues.apache.org/jira/browse/CSV-195