Fix CSVFileParserTest.java to allow for a null return value from record.getComment()#62
Merged
Merged
Conversation
…d.getComment() be null the test code misplace the null test. Add a new test file that record.getComment() will be null and test record.getComment() no null before using
garydgregory
requested changes
Mar 23, 2020
| String parsed = Arrays.toString(record.values()); | ||
| if (checkComments) { | ||
| final String comment = record.getComment().replace("\n", "\\n"); | ||
| if (comment != null) { |
Member
There was a problem hiding this comment.
Let's keep the caching of "record.getComment()"
Contributor
Author
There was a problem hiding this comment.
thanks for review , I have fix that
| if (comment != null) { | ||
| parsed += "#" + comment; | ||
| } | ||
| if (checkComments && record.getComment() != null) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old test case record.getComment() will never be null and if record.getComment() be null the test code misplace the null test.
Add a new test file that record.getComment() will be null and test record.getComment() no null before using.