Change JiraCsv164Test to JiraCsv154Test#69
Merged
Conversation
Contributor
Author
|
The content of this file is the test case of CSV-154. So the name should be modified to JiraCsv154Test. |
Member
|
@dota17 Please stop creating PRs while leaving the description field empty. Reviewed should not have to parse out your changes to try and understand why a PR is needed. In this specific case, the description should state why you are making this change: Has the test code's purpose changed? Was it never called the right name in the first place? Or, was the Jira ticket itself changed? |
Member
Then say that in the description! |
Contributor
Author
|
@garydgregory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.