Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixing checkstyle failures
  • Loading branch information
mufasa1976 committed May 20, 2024
commit 96e3573bcd042faf93a61c91d65cca87f7e15b3d
2 changes: 1 addition & 1 deletion commons-fileupload2-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
<commons.jacoco.instructionRatio>0.43</commons.jacoco.instructionRatio>
<commons.jacoco.methodRatio>0.40</commons.jacoco.methodRatio>
<commons.jacoco.branchRatio>0.43</commons.jacoco.branchRatio>
<commons.jacoco.lineRatio>0.41</commons.jacoco.lineRatio>
<commons.jacoco.lineRatio>0.42</commons.jacoco.lineRatio>
<commons.jacoco.complexityRatio>0.37</commons.jacoco.complexityRatio>
</properties>
<dependencies>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

public abstract class AbstractRequestContext<T> implements RequestContext {
/**
* the Content-Type Pattern for multipart/related Requests
* the Content-Type Pattern for multipart/related Requests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentences start with a capital letter.

*/
private static final Pattern MULTIPART_RELATED =
Pattern.compile("^\\s*multipart/related.*", Pattern.CASE_INSENSITIVE);
Expand Down Expand Up @@ -85,7 +85,7 @@ public String toString() {
return String.format("%s [ContentLength=%s, ContentType=%s]", getClass().getSimpleName(), getContentLength(), getContentType());
}

protected boolean isMultipartRelated(String contentType) {
protected boolean isMultipartRelated(final String contentType) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New protected and public items should have a Javadoc and since tag.

return MULTIPART_RELATED.matcher(contentType).matches();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class FileItemInputIteratorImpl implements FileItemInputIterator {
private boolean eof;

/**
* is the Request of type <code>multipart/related</code>
* is the Request of type <code>multipart/related</code>.
*/
private final boolean multipartRelated;

Expand Down