Use final for parameters.

Author: garydgregory

src/main/java/org/apache/commons/io/FileSystemUtils.java

@@ -293,7 +293,7 @@ long freeSpaceOS(final String path, final int os, final boolean kb, final long t
      * @return the amount of free drive space on the drive
      * @throws IOException if an error occurs
      */
-    long freeSpaceWindows(String path, final long timeout) throws IOException {
+    long freeSpaceWindows(final String path, final long timeout) throws IOException {
         String normPath = FilenameUtils.normalize(path, false);
         if (normPath == null) {
             throw new IllegalArgumentException(path);

src/main/java/org/apache/commons/io/FileUtils.java

@@ -1372,7 +1372,7 @@ public static void copyDirectory(final File srcDir, final File destDir,
      * @param dest the destination
      * @throws FileNotFoundException if the destination does not exist
      */
-    private static void checkFileRequirements(File src, File dest) throws FileNotFoundException {
+    private static void checkFileRequirements(final File src, final File dest) throws FileNotFoundException {
         if (src == null) {
             throw new NullPointerException("Source must not be null");
         }
@@ -1735,7 +1735,7 @@ public static void cleanDirectory(final File directory) throws IOException {
      * @return The files in the directory, never null.
      * @throws IOException if an I/O error occurs
      */
-    private static File[] verifiedListFiles(File directory) throws IOException {
+    private static File[] verifiedListFiles(final File directory) throws IOException {
         if (!directory.exists()) {
             final String message = directory + " does not exist";
             throw new IllegalArgumentException(message);
@@ -2636,7 +2636,7 @@ private static long sizeOfDirectory0(final File directory) {
      * @param file the file to check
      * @return the size of the file
      */
-    private static long sizeOf0(File file) {
+    private static long sizeOf0(final File file) {
         if (file.isDirectory()) {
             return sizeOfDirectory0(file);
         } else {

src/main/java/org/apache/commons/io/FilenameUtils.java

@@ -982,7 +982,7 @@ public static String getName(final String filename) {
      * This may be used for poison byte attacks.
      * @param path the path to check
      */
-    private static void failIfNullBytePresent(String path) {
+    private static void failIfNullBytePresent(final String path) {
         int len = path.length();
         for (int i = 0; i < len; i++) {
             if (path.charAt(i) == 0) {

src/main/java/org/apache/commons/io/IOUtils.java

@@ -585,7 +585,7 @@ public static InputStream toBufferedInputStream(final InputStream input) throws
      * @throws IOException if an I/O error occurs
      * @since 2.5
      */
-    public static InputStream toBufferedInputStream(final InputStream input, int size) throws IOException {
+    public static InputStream toBufferedInputStream(final InputStream input, final int size) throws IOException {
         return ByteArrayOutputStream.toBufferedInputStream(input, size);
     }
 
@@ -614,7 +614,7 @@ public static BufferedReader toBufferedReader(final Reader reader) {
      * @see #buffer(Reader)
      * @since 2.5
      */
-    public static BufferedReader toBufferedReader(final Reader reader, int size) {
+    public static BufferedReader toBufferedReader(final Reader reader, final int size) {
         return reader instanceof BufferedReader ? (BufferedReader) reader : new BufferedReader(reader, size);
     }
 
@@ -641,7 +641,7 @@ public static BufferedReader buffer(final Reader reader) {
      * @throws NullPointerException if the input parameter is null
      * @since 2.5
      */
-    public static BufferedReader buffer(final Reader reader, int size) {
+    public static BufferedReader buffer(final Reader reader, final int size) {
         return reader instanceof BufferedReader ? (BufferedReader) reader : new BufferedReader(reader, size);
     }
 
@@ -668,7 +668,7 @@ public static BufferedWriter buffer(final Writer writer) {
      * @throws NullPointerException if the input parameter is null
      * @since 2.5
      */
-    public static BufferedWriter buffer(final Writer writer, int size) {
+    public static BufferedWriter buffer(final Writer writer, final int size) {
         return writer instanceof BufferedWriter ? (BufferedWriter) writer : new BufferedWriter(writer, size);
     }
 
@@ -700,7 +700,7 @@ public static BufferedOutputStream buffer(final OutputStream outputStream) {
      * @throws NullPointerException if the input parameter is null
      * @since 2.5
      */
-    public static BufferedOutputStream buffer(final OutputStream outputStream, int size) {
+    public static BufferedOutputStream buffer(final OutputStream outputStream, final int size) {
         // reject null early on rather than waiting for IO operation to fail
         if (outputStream == null) { // not checked by BufferedOutputStream
             throw new NullPointerException();
@@ -737,7 +737,7 @@ public static BufferedInputStream buffer(final InputStream inputStream) {
      * @throws NullPointerException if the input parameter is null
      * @since 2.5
      */
-    public static BufferedInputStream buffer(final InputStream inputStream, int size) {
+    public static BufferedInputStream buffer(final InputStream inputStream, final int size) {
         // reject null early on rather than waiting for IO operation to fail
         if (inputStream == null) { // not checked by BufferedInputStream
             throw new NullPointerException();
@@ -1289,7 +1289,7 @@ public static String resourceToString(final String name, final Charset encoding)
      *
      * @since 2.6
      */
-    public static String resourceToString(final String name, final Charset encoding, ClassLoader classLoader) throws IOException {
+    public static String resourceToString(final String name, final Charset encoding, final ClassLoader classLoader) throws IOException {
         return toString(resourceToURL(name, classLoader), encoding);
     }
 

src/main/java/org/apache/commons/io/ThreadMonitor.java

@@ -121,7 +121,7 @@ public void run() {
      * @param ms the number of milliseconds to sleep for
      * @throws InterruptedException if interrupted
      */
-    private static void sleep(long ms) throws InterruptedException {
+    private static void sleep(final long ms) throws InterruptedException {
         long finishAt = System.currentTimeMillis() + ms;
         long remaining = ms;
         do {

src/main/java/org/apache/commons/io/input/BOMInputStream.java

@@ -401,7 +401,7 @@ public synchronized void reset() throws IOException {
      *             if an I/O error occurs
      */
     @Override
-    public long skip(long n) throws IOException {
+    public long skip(final long n) throws IOException {
         int skipped = 0;
         while ((n > skipped) && (readFirstBytes() >= 0)) {
             skipped++;

src/main/java/org/apache/commons/io/input/BoundedReader.java

@@ -57,7 +57,7 @@ public class BoundedReader
      * @param maxCharsFromTargetReader The maximum number of characters that can be read from target
      * @throws IOException if mark fails
      */
-    public BoundedReader( Reader target, int maxCharsFromTargetReader ) throws IOException {
+    public BoundedReader( final Reader target, final int maxCharsFromTargetReader ) throws IOException {
         this.target = target;
         this.maxCharsFromTargetReader = maxCharsFromTargetReader;
     }
@@ -98,7 +98,7 @@ public void reset() throws IOException {
      * @see java.io.Reader#mark(int).
      */
     @Override
-    public void mark( int readAheadLimit ) throws IOException {
+    public void mark( final int readAheadLimit ) throws IOException {
         this.readAheadLimit = readAheadLimit - charsRead;
 
         markedAt = charsRead;
@@ -138,7 +138,7 @@ public int read() throws IOException {
      * @see java.io.Reader#read(char[], int, int)
      */
     @Override
-    public int read( char[] cbuf, int off, int len ) throws IOException {
+    public int read( final char[] cbuf, final int off, final int len ) throws IOException {
         int c;
         for ( int i = 0; i < len; i++ ) {
             c = read();

src/main/java/org/apache/commons/io/input/InfiniteCircularInputStream.java

@@ -38,7 +38,7 @@ public class InfiniteCircularInputStream extends InputStream {
      * @param repeatedContent
      *            Input buffer to be repeated (not copied)
      */
-    public InfiniteCircularInputStream(byte[] repeatedContent) {
+    public InfiniteCircularInputStream(final byte[] repeatedContent) {
         this.repeatedContent = repeatedContent;
     }
 

src/main/java/org/apache/commons/io/input/MessageDigestCalculatingInputStream.java

@@ -41,17 +41,17 @@ public static class MessageDigestMaintainingObserver extends Observer {
          * Creates an MessageDigestMaintainingObserver for the given MessageDigest.
          * @param pMd the message digest to use
          */
-        public MessageDigestMaintainingObserver(MessageDigest pMd) {
+        public MessageDigestMaintainingObserver(final MessageDigest pMd) {
             md = pMd;
         }
 
         @Override
-        void data(int pByte) throws IOException {
+        void data(final int pByte) throws IOException {
             md.update((byte) pByte);
         }
 
         @Override
-        void data(byte[] pBuffer, int pOffset, int pLength) throws IOException {
+        void data(final byte[] pBuffer, final int pOffset, final int pLength) throws IOException {
             md.update(pBuffer, pOffset, pLength);
         }
     }
@@ -63,7 +63,7 @@ void data(byte[] pBuffer, int pOffset, int pLength) throws IOException {
      * @param pStream the stream to calculate the message digest for
      * @param pDigest the message digest to use
      */
-    public MessageDigestCalculatingInputStream(InputStream pStream, MessageDigest pDigest) {
+    public MessageDigestCalculatingInputStream(final InputStream pStream, final MessageDigest pDigest) {
         super(pStream);
         messageDigest = pDigest;
         add(new MessageDigestMaintainingObserver(pDigest));
@@ -75,7 +75,7 @@ public MessageDigestCalculatingInputStream(InputStream pStream, MessageDigest pD
      * @param pAlgorithm the name of the algorithm to use
      * @throws NoSuchAlgorithmException if no Provider supports a MessageDigestSpi implementation for the specified algorithm.
      */
-    public MessageDigestCalculatingInputStream(InputStream pStream, String pAlgorithm) throws NoSuchAlgorithmException {
+    public MessageDigestCalculatingInputStream(final InputStream pStream, final String pAlgorithm) throws NoSuchAlgorithmException {
         this(pStream, MessageDigest.getInstance(pAlgorithm));
     }
 
@@ -84,7 +84,7 @@ public MessageDigestCalculatingInputStream(InputStream pStream, String pAlgorith
      * @param pStream the stream to calculate the message digest for
      * @throws NoSuchAlgorithmException if no Provider supports a MessageDigestSpi implementation for the specified algorithm.
      */
-    public MessageDigestCalculatingInputStream(InputStream pStream) throws NoSuchAlgorithmException {
+    public MessageDigestCalculatingInputStream(final InputStream pStream) throws NoSuchAlgorithmException {
         this(pStream, MessageDigest.getInstance("MD5"));
     }
 

src/main/java/org/apache/commons/io/input/ObservableInputStream.java

@@ -44,7 +44,7 @@ public static abstract class Observer {
          *    because, in that case, {@link #finished()} will be invoked instead.
          * @throws IOException if an i/o-error occurs
          */
-        void data(int pByte) throws IOException {}
+        void data(final int pByte) throws IOException {}
 
         /** Called to indicate, that {@link InputStream#read(byte[])}, or
          * {@link InputStream#read(byte[], int, int)} have been called, and are about to
@@ -55,7 +55,7 @@ void data(int pByte) throws IOException {}
          * @param pLength The number of bytes, which have been stored in the byte array.
          * @throws IOException if an i/o-error occurs
          */
-        void data(byte[] pBuffer, int pOffset, int pLength) throws IOException {}
+        void data(final byte[] pBuffer, final int pOffset, final int pLength) throws IOException {}
 
         /** Called to indicate, that EOF has been seen on the underlying stream.
          * This method may be called multiple times, if the reader keeps invoking
@@ -74,7 +74,7 @@ void closed() throws IOException {}
          * Called to indicate, that an error occurred on the underlying stream.
          * @throws IOException if an i/o-error occurs
          */
-        void error(IOException pException) throws IOException { throw pException; }
+        void error(final IOException pException) throws IOException { throw pException; }
     }
 
     private final List<Observer> observers = new ArrayList<>();
@@ -83,23 +83,23 @@ void closed() throws IOException {}
      * Creates a new ObservableInputStream for the given InputStream.
      * @param pProxy the input stream to proxy
      */
-    public ObservableInputStream(InputStream pProxy) {
+    public ObservableInputStream(final InputStream pProxy) {
         super(pProxy);
     }
 
     /**
      * Adds an Observer.
      * @param pObserver the observer to add
      */
-    public void add(Observer pObserver) {
+    public void add(final Observer pObserver) {
         observers.add(pObserver);
     }
 
     /**
      * Removes an Observer.
      * @param pObserver the observer to remove
      */
-    public void remove(Observer pObserver) {
+    public void remove(final Observer pObserver) {
         observers.remove(pObserver);
     }
 
@@ -130,7 +130,7 @@ public int read() throws IOException {
     }
 
     @Override
-    public int read(byte[] pBuffer) throws IOException {
+    public int read(final byte[] pBuffer) throws IOException {
         int result = 0;
         IOException ioe = null;
         try {
@@ -149,7 +149,7 @@ public int read(byte[] pBuffer) throws IOException {
     }
 
     @Override
-    public int read(byte[] pBuffer, int pOffset, int pLength) throws IOException {
+    public int read(final byte[] pBuffer, final int pOffset, final int pLength) throws IOException {
         int result = 0;
         IOException ioe = null;
         try {
@@ -175,7 +175,7 @@ public int read(byte[] pBuffer, int pOffset, int pLength) throws IOException {
      * @throws IOException Some observer has thrown an exception, which is being
      *   passed down.
      */
-    protected void noteDataBytes(byte[] pBuffer, int pOffset, int pLength) throws IOException {
+    protected void noteDataBytes(final byte[] pBuffer, final int pOffset, final int pLength) throws IOException {
         for (Observer observer : getObservers()) {
             observer.data(pBuffer, pOffset, pLength);
         }
@@ -197,7 +197,7 @@ protected void noteFinished() throws IOException {
      * @throws IOException Some observer has thrown an exception, which is being
      *   passed down.
      */
-    protected void noteDataByte(int pDataByte) throws IOException {
+    protected void noteDataByte(final int pDataByte) throws IOException {
         for (Observer observer : getObservers()) {
             observer.data(pDataByte);
         }
@@ -210,7 +210,7 @@ protected void noteDataByte(int pDataByte) throws IOException {
      *   passed down. This may be the same exception, which has been passed as an
      *   argument.
      */
-    protected void noteError(IOException pException) throws IOException {
+    protected void noteError(final IOException pException) throws IOException {
         for (Observer observer : getObservers()) {
             observer.error(pException);
         }