Skip to content

Commit 75b79c7

Browse files
Tiny performance improvements. (#163)
1 parent 4d3a6bb commit 75b79c7

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

src/main/java/org/apache/commons/io/FileUtils.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -714,13 +714,15 @@ public static void copyDirectory(final File srcDir, final File destDir, final Fi
714714
if (!srcDir.isDirectory()) {
715715
throw new IOException("Source '" + srcDir + "' exists but is not a directory");
716716
}
717-
if (srcDir.getCanonicalPath().equals(destDir.getCanonicalPath())) {
717+
final String srcDirCanonicalPath = srcDir.getCanonicalPath();
718+
final String destDirCanonicalPath = destDir.getCanonicalPath();
719+
if (srcDirCanonicalPath.equals(destDirCanonicalPath)) {
718720
throw new IOException("Source '" + srcDir + "' and destination '" + destDir + "' are the same");
719721
}
720722

721723
// Cater for destination being directory within the source directory (see IO-141)
722724
List<String> exclusionList = null;
723-
if (destDir.getCanonicalPath().startsWith(srcDir.getCanonicalPath())) {
725+
if (destDirCanonicalPath.startsWith(srcDirCanonicalPath)) {
724726
final File[] srcFiles = filter == null ? srcDir.listFiles() : srcDir.listFiles(filter);
725727
if (srcFiles != null && srcFiles.length > 0) {
726728
exclusionList = new ArrayList<>(srcFiles.length);

0 commit comments

Comments
 (0)