FileUtils copyDirectory(File, File, FileFilter, preserveFileDate) clean up#163
Merged
Conversation
Member
|
Looks reasonable even without the performance minor issue, for me, the code is less cluttered with this refactoring. TY! :-) |
asfgit
pushed a commit
that referenced
this pull request
Oct 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that copyDirectory(final File srcDir, final File destDir, final FileFilter filter, final boolean preserveFileDate) executes getCanonicalPath() multiple times on the same path. I might be wrong, but that seems wasteful. So, I created this pull request.
I created a unit test based on jmh and it seemed to indicate that the performance indeed improves. However, I am not an expert on benchmarking and profiling and I cannot explain all results. Don't hesitate to show where I went wrong and/or might improve.
See https://github.com/michielgkalkman/PmdPlus/tree/master/src/test/java/org/taHjaj/wo/pmdplus/dup/jmh/org/apache/commons/io (or: michielgkalkman/PmdPlus@10d4495) for some background on what I did test..