Skip to content

Commit 99a353b

Browse files
remove TemporaryFolder Rule from test classes that do not use it
1 parent 14b52eb commit 99a353b

5 files changed

Lines changed: 0 additions & 48 deletions

File tree

src/test/java/org/apache/commons/io/CopyUtilsTest.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import static org.junit.Assert.assertTrue;
2121

2222
import java.io.ByteArrayInputStream;
23-
import java.io.File;
2423
import java.io.InputStream;
2524
import java.io.OutputStream;
2625
import java.io.Reader;
@@ -32,9 +31,7 @@
3231
import org.apache.commons.io.testtools.TestUtils;
3332
import org.apache.commons.io.testtools.YellOnCloseInputStream;
3433
import org.apache.commons.io.testtools.YellOnFlushAndCloseOutputStream;
35-
import org.junit.ClassRule;
3634
import org.junit.Test;
37-
import org.junit.rules.TemporaryFolder;
3835

3936
@SuppressWarnings("deprecation") // these are test cases for the deprecated CopyUtils
4037

@@ -45,13 +42,6 @@
4542
*/
4643
public class CopyUtilsTest {
4744

48-
@ClassRule
49-
public static TemporaryFolder temporaryFolder = new TemporaryFolder();
50-
51-
private static File getTestDirectory() {
52-
return temporaryFolder.getRoot();
53-
}
54-
5545
/*
5646
* NOTE this is not particularly beautiful code. A better way to check for
5747
* flush and close status would be to implement "trojan horse" wrapper
@@ -61,7 +51,6 @@ private static File getTestDirectory() {
6151

6252
private static final int FILE_SIZE = 1024 * 4 + 1;
6353

64-
6554
private final byte[] inData = TestUtils.generateTestData(FILE_SIZE);
6655

6756
// ----------------------------------------------------------------

src/test/java/org/apache/commons/io/FileSystemUtilsTestCase.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,23 +29,14 @@
2929
import java.util.Locale;
3030

3131
import org.junit.Assert;
32-
import org.junit.ClassRule;
3332
import org.junit.Test;
34-
import org.junit.rules.TemporaryFolder;
3533

3634
/**
3735
* This is used to test FileSystemUtils.
3836
*
3937
*/
4038
public class FileSystemUtilsTestCase {
4139

42-
@ClassRule
43-
public static TemporaryFolder temporaryFolder = new TemporaryFolder();
44-
45-
private static File getTestDirectory() {
46-
return temporaryFolder.getRoot();
47-
}
48-
4940
//-----------------------------------------------------------------------
5041
@Test
5142
@SuppressWarnings("deprecation") // testing decrecated code

src/test/java/org/apache/commons/io/IOCaseTestCase.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,23 +28,14 @@
2828
import java.io.ObjectInputStream;
2929
import java.io.ObjectOutputStream;
3030

31-
import org.junit.ClassRule;
3231
import org.junit.Test;
33-
import org.junit.rules.TemporaryFolder;
3432

3533
/**
3634
* This is used to test IOCase for correctness.
3735
*
3836
*/
3937
public class IOCaseTestCase {
4038

41-
@ClassRule
42-
public static TemporaryFolder temporaryFolder = new TemporaryFolder();
43-
44-
private static File getTestDirectory() {
45-
return temporaryFolder.getRoot();
46-
}
47-
4839
private static final boolean WINDOWS = File.separatorChar == '\\';
4940

5041
//-----------------------------------------------------------------------

src/test/java/org/apache/commons/io/IOUtilsCopyTestCase.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,7 @@
3737
import org.apache.commons.io.testtools.TestUtils;
3838
import org.apache.commons.io.testtools.YellOnCloseInputStream;
3939
import org.apache.commons.io.testtools.YellOnFlushAndCloseOutputStream;
40-
import org.junit.ClassRule;
4140
import org.junit.Test;
42-
import org.junit.rules.TemporaryFolder;
4341

4442
/**
4543
* JUnit tests for IOUtils copy methods.
@@ -48,13 +46,6 @@
4846
*/
4947
public class IOUtilsCopyTestCase {
5048

51-
@ClassRule
52-
public static TemporaryFolder temporaryFolder = new TemporaryFolder();
53-
54-
private static File getTestDirectory() {
55-
return temporaryFolder.getRoot();
56-
}
57-
5849
/*
5950
* NOTE this is not particularly beautiful code. A better way to check for
6051
* flush and close status would be to implement "trojan horse" wrapper

src/test/java/org/apache/commons/io/IOUtilsWriteTestCase.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import static org.junit.Assert.assertTrue;
2121
import static org.junit.Assert.fail;
2222

23-
import java.io.File;
2423
import java.io.OutputStream;
2524
import java.io.OutputStreamWriter;
2625
import java.io.Writer;
@@ -30,9 +29,7 @@
3029
import org.apache.commons.io.output.ByteArrayOutputStream;
3130
import org.apache.commons.io.testtools.TestUtils;
3231
import org.apache.commons.io.testtools.YellOnFlushAndCloseOutputStream;
33-
import org.junit.ClassRule;
3432
import org.junit.Test;
35-
import org.junit.rules.TemporaryFolder;
3633

3734
/**
3835
* JUnit tests for IOUtils write methods.
@@ -42,13 +39,6 @@
4239
@SuppressWarnings("deprecation") // includes tests for deprecated methods
4340
public class IOUtilsWriteTestCase {
4441

45-
@ClassRule
46-
public static TemporaryFolder temporaryFolder = new TemporaryFolder();
47-
48-
private static File getTestDirectory() {
49-
return temporaryFolder.getRoot();
50-
}
51-
5242
private static final int FILE_SIZE = 1024 * 4 + 1;
5343

5444
private final byte[] inData = TestUtils.generateTestData(FILE_SIZE);

0 commit comments

Comments
 (0)