Unsynchronized ByteArrayInputStream implementation#109
Merged
Conversation
garydgregory
requested changes
Apr 9, 2020
garydgregory
left a comment
Member
There was a problem hiding this comment.
@adamretter
Thank you for your PR. Please see my comments.
| private int markedOffset; | ||
|
|
||
| /** | ||
| * @param data the buffer |
Member
There was a problem hiding this comment.
You are missing a comment here.
| } | ||
|
|
||
| /** | ||
| * @param data the buffer |
Member
There was a problem hiding this comment.
You are missing a comment here.
|
|
||
|
|
||
| /** | ||
| * @param data the buffer |
Member
There was a problem hiding this comment.
You are missing a comment here.
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static org.apache.commons.io.input.UnsynchronizedByteArrayInputStream.END_OF_STREAM; | ||
| import static org.junit.jupiter.api.Assertions.*; |
| /** | ||
| * Basic unit tests for the alternative ByteArrayInputStream implementation. | ||
| */ | ||
| public class UnsynchronizedByteArrayInputStreamTest { |
Member
There was a problem hiding this comment.
For new files, I like to keep method in alphabetical order, it makes it easier to find stuff.
15 tasks
Contributor
Author
|
Thanks @garydgregory I have just pushed a commit addressing your feedback. |
Member
brettlounsbury
pushed a commit
to brettlounsbury/commons-io
that referenced
this pull request
May 28, 2020
* Add a non-synchronized ByteArrayInputStream implementation - FastByteArrayInputStream * Address review comments by @garydgregory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds upon the previous work of #108 by adding an
UnsynchronizedByteArrayInputStream.Calls to
UnsynchronizedByteArrayOutputStream#toInputStream()now returnUnsynchronizedByteArrayInputStreamas the implementation instead ofjava.io.ByteArrayInputStream.