Skip to content

Implement CharSequenceReader.ready#122

Merged
garydgregory merged 1 commit into
apache:masterfrom
robtimus:CharSequenceReader.ready
Jul 9, 2020
Merged

Implement CharSequenceReader.ready#122
garydgregory merged 1 commit into
apache:masterfrom
robtimus:CharSequenceReader.ready

Conversation

@robtimus

@robtimus robtimus commented Jul 8, 2020

Copy link
Copy Markdown
Contributor

Reader.ready() should return

True if the next read() is guaranteed not to block for input, false otherwise

The default implementation is to return false, and that's what CharSequenceReader inherits. This change overrides ready() to return true if there characters can still be returned.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.07%) to 89.774% when pulling 4fa7b50 on robtimus:CharSequenceReader.ready into 821ab5f on apache:master.

@robtimus

robtimus commented Jul 9, 2020

Copy link
Copy Markdown
Contributor Author

I've seen that the Travis build has failed, but that's a test unrelated to this change. I don't know why it fails though.

@garydgregory

Copy link
Copy Markdown
Member

I've restarted the build, that tailer test has failed 'randomly' in the past.

@robtimus

robtimus commented Jul 9, 2020

Copy link
Copy Markdown
Contributor Author

Thanks, it's green now as it should be.

@garydgregory garydgregory merged commit 6c06f5b into apache:master Jul 9, 2020
@garydgregory garydgregory changed the title Implemented CharSequenceReader.ready Implement CharSequenceReader.ready Jul 9, 2020
asfgit pushed a commit that referenced this pull request Jul 9, 2020
@robtimus robtimus deleted the CharSequenceReader.ready branch December 6, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants