Skip to content

IO-719: Fixed error of copying directories between different file systems#203

Closed
ashcheglov wants to merge 6 commits into
apache:masterfrom
ashcheglov:master
Closed

IO-719: Fixed error of copying directories between different file systems#203
ashcheglov wants to merge 6 commits into
apache:masterfrom
ashcheglov:master

Conversation

@ashcheglov

Copy link
Copy Markdown

Also fixed relativize error for different types of paths
(absolute/relative)

Andrey Shcheglov added 2 commits February 9, 2021 13:01
Also fixed relativize error for different types of paths
(absolute/relative)
bug report: IO-719

@garydgregory garydgregory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tabs please. See broken build.

Comment thread src/main/java/org/apache/commons/io/file/CopyDirectoryVisitor.java
Andrey Shcheglov added 2 commits February 9, 2021 15:29
@coveralls

coveralls commented Feb 9, 2021

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 89.25% when pulling bd0d6f4 on ashcheglov:master into 40b9af5 on apache:master.

@ashcheglov

Copy link
Copy Markdown
Author

Looks like all checks passed, excluding early access environments

Comment thread src/main/java/org/apache/commons/io/file/CopyDirectoryVisitor.java
@garydgregory garydgregory changed the title IO-719: Fixed error of copying directories between different filesystems IO-719: Fixed error of copying directories between different file systems Feb 10, 2021
asfgit pushed a commit that referenced this pull request Feb 10, 2021
#203 by Andrew Shcheglov
(ashcheglov on GitHub).
asfgit pushed a commit that referenced this pull request Feb 10, 2021
#203 by Andrew Shcheglov
(ashcheglov on GitHub).
@garydgregory

Copy link
Copy Markdown
Member

@ashcheglov
Thank you for your PR, I applied the patch in two separate commits with additional clean ups and minor refactoring. Please see git master and close this PR if your use case is satified.

@ashcheglov

Copy link
Copy Markdown
Author

Cool, thanks!

@ashcheglov ashcheglov closed this Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants