fixed IO-447#21
Closed
MengshiZhang wants to merge 1 commit into
Closed
Conversation
PascalSchumacher
suggested changes
Nov 22, 2016
PascalSchumacher
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the pull request.
| * @throws IOException if an error occurs, NullPointerException if path cannot be parsed by FilenameUtils.normalize() | ||
| */ | ||
| long freeSpaceWindows(String path, final long timeout) throws IOException { | ||
| long freeSpaceWindows(String path, final long timeout) throws IOException, NullPointerException { |
Contributor
There was a problem hiding this comment.
NullPointerException is a RuntimeException so it should be part of the method signature.
| * is zero or less | ||
| * @return the amount of free drive space on the drive | ||
| * @throws IOException if an error occurs | ||
| * @throws IOException if an error occurs, NullPointerException if path cannot be parsed by FilenameUtils.normalize() |
Contributor
There was a problem hiding this comment.
this should be a separate throws declaration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.