Prevent infinite loop with AbstractCharacterFilterReader if EOF is filtered out#226
Closed
robtimus wants to merge 1 commit into
Closed
Prevent infinite loop with AbstractCharacterFilterReader if EOF is filtered out#226robtimus wants to merge 1 commit into
robtimus wants to merge 1 commit into
Conversation
Member
|
@robtimus |
Contributor
Author
|
@garydgregory |
Member
|
What is duplicated? |
Contributor
Author
|
I had added the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractCharacterFilterReader.read()only aborts its loop iffilter(ch)returns false. If that method returnstruefor EOF, you'll get an infinite loop if the backingread()call keeps returning EOF. That's really easy to achieve withCharacterFilterReader.This small fix aborts the loop not only if
filter(ch)returns false, but also if the backingread()call returns EOF.