Skip to content

IO-747 Make commons-io a proper JPMS module #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jochenw merged 3 commits into from
Sep 17, 2021
Merged

IO-747 Make commons-io a proper JPMS module #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
414979f
IO-747 Make commons-io a proper JPMS module
martin-g Sep 3, 2021
7854f80
IO-747 Change the name of the JPMS module
martin-g Sep 13, 2021
6c97a6d
IO-747 Enable moditect plugin when building with Java 9+
martin-g Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 65 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,10 @@ file comparators, endian transformation classes, and much more.
<contributor>
<name>Frank W. Zammetti</name>
</contributor>
<contributor>
<name>Martin Grigorov</name>
<email>mgrigorov@apache.org</email>
</contributor>
</contributors>

<dependencyManagement>
Expand Down Expand Up @@ -334,13 +338,15 @@ file comparators, endian transformation classes, and much more.
<commons.jacoco.version>0.8.7</commons.jacoco.version>
<commons.surefire.version>3.0.0-M5</commons.surefire.version>
<commons.japicmp.version>0.15.3</commons.japicmp.version>
<commons.enforcer.version>3.0.0</commons.enforcer.version>
<commons.moditect.version>1.0.0.RC1</commons.moditect.version>
<spotbugs.plugin.version>4.3.0</spotbugs.plugin.version>
<spotbugs.impl.version>4.4.1</spotbugs.impl.version>
<jmh.version>1.33</jmh.version>
<jmh.version>1.33</jmh.version>
<japicmp.skip>false</japicmp.skip>
<jacoco.skip>${env.JACOCO_SKIP}</jacoco.skip>
<commons.release.isDistModule>true</commons.release.isDistModule>
<commons.releaseManagerName>Gary Gregory</commons.releaseManagerName>
<commons.releaseManagerName>Gary Gregory</commons.releaseManagerName>
<commons.releaseManagerKey>86fdc7e2a11262cb</commons.releaseManagerKey>
</properties>

Expand Down Expand Up @@ -383,7 +389,7 @@ file comparators, endian transformation classes, and much more.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<version>3.0.0</version>
<version>${commons.enforcer.version}</version>
<executions>
<execution>
<id>enforce-maven</id>
Expand Down Expand Up @@ -559,7 +565,36 @@ file comparators, endian transformation classes, and much more.
<properties>
<!-- coverall version 4.3.0 does not work with java 9, see https://github.com/trautonen/coveralls-maven-plugin/issues/112 -->
<coveralls.skip>true</coveralls.skip>
<maven.compiler.release>8</maven.compiler.release>
</properties>
<build>
<plugins>
<plugin>
<groupId>org.moditect</groupId>
<artifactId>moditect-maven-plugin</artifactId>
<version>${commons.moditect.version}</version>
<executions>
<execution>
<id>add-module-infos</id>
<phase>package</phase>
<goals>
<goal>add-module-info</goal>
</goals>
<configuration>
<jvmVersion>9</jvmVersion>
<outputDirectory>${project.build.directory}</outputDirectory>
<overwriteExistingFiles>true</overwriteExistingFiles>
<module>
<moduleInfo>
<name>org.apache.commons.io</name>
</moduleInfo>
</module>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>benchmark</id>
Expand Down Expand Up @@ -600,5 +635,32 @@ file comparators, endian transformation classes, and much more.
</plugins>
</build>
</profile>
<profile>
<id>release</id>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<version>${commons.enforcer.version}</version>
<executions>
<execution>
<id>enforce-versions</id>
<goals>
<goal>enforce</goal>
</goals>
<configuration>
<rules>
<requireJavaVersion>
<version>9</version>
</requireJavaVersion>
</rules>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
</profiles>
</project>
3 changes: 3 additions & 0 deletions src/changes/changes.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,9 @@ The <action> type attribute can be add,update,fix,remove.
<action dev="ggregory" type="update" due-to="Dependabot">
Bump jmh.version from 1.32 to 1.33 #258.
</action>
<action dev="mgrigorov" type="update">
IO-747 Make commons-io a JPMS module by adding module-info.class.
</action>
</release>
<release version="2.11.0" date="2021-07-09" description="Java 8 required.">
<!-- FIX -->
Expand Down