Skip to content

Fix usage of assertNotNull#269

Merged
garydgregory merged 1 commit into
apache:masterfrom
dfa1:fix-745
Sep 3, 2021
Merged

Fix usage of assertNotNull#269
garydgregory merged 1 commit into
apache:masterfrom
dfa1:fix-745

Conversation

@dfa1

@dfa1 dfa1 commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

Signature of assertNoNull() is taking "actual" as first parameter:

public static void assertNotNull(Object actual, String message) {
    AssertNotNull.assertNotNull(actual, message);
}

Signed-off-by: Davide Angelocola davide.angelocola@gmail.com

Signature of assertNoNull() is taking "actual" as first parameter:

    public static void assertNotNull(Object actual, String message) {
        AssertNotNull.assertNotNull(actual, message);
    }

Signed-off-by: Davide Angelocola <davide.angelocola@gmail.com>
@dfa1

dfa1 commented Sep 3, 2021

Copy link
Copy Markdown
Contributor Author

@garydgregory can you please review this as well?

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.1%) to 89.251% when pulling 820cfd9 on dfa1:fix-745 into 072fa70 on apache:master.

@garydgregory garydgregory changed the title fix wrong usage of assertNotNull Fix usage of assertNotNull Sep 3, 2021
@garydgregory garydgregory merged commit a1fd31d into apache:master Sep 3, 2021
asfgit pushed a commit that referenced this pull request Sep 3, 2021
@dfa1 dfa1 deleted the fix-745 branch September 3, 2021 17:09
@dfa1 dfa1 restored the fix-745 branch September 3, 2021 17:10
@dfa1 dfa1 deleted the fix-745 branch September 3, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants