Skip to content

Prevent IllegalArgumentExceptions in BrokenInputStream/Reader/OutputStream/Writer#278

Merged
garydgregory merged 2 commits into
apache:masterfrom
robtimus:IO-729
Sep 28, 2021
Merged

Prevent IllegalArgumentExceptions in BrokenInputStream/Reader/OutputStream/Writer#278
garydgregory merged 2 commits into
apache:masterfrom
robtimus:IO-729

Conversation

@robtimus

Copy link
Copy Markdown
Contributor

…to prevent IllegalArgumentExceptions in try-with-resources

@garydgregory garydgregory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robtimus
Looks good mod a few comments I've sprinkled that should apply throughout.
TY!

Comment thread src/main/java/org/apache/commons/io/output/BrokenWriter.java Outdated
Comment thread src/test/java/org/apache/commons/io/input/BrokenInputStreamTest.java Outdated
Comment thread src/test/java/org/apache/commons/io/input/BrokenReaderTest.java Outdated
@garydgregory

Copy link
Copy Markdown
Member

@garydgregory garydgregory changed the title BrokenInputStream/Reader/OutputStream/Writer use a supplier … Prevent IllegalArgumentExceptions in BrokenInputStream/Reader/OutputStream/Writer Sep 28, 2021
@robtimus

Copy link
Copy Markdown
Contributor Author

@garydgregory I've added periods and made all new variables in the tests final.

@garydgregory garydgregory merged commit 0c00862 into apache:master Sep 28, 2021
asfgit pushed a commit that referenced this pull request Sep 28, 2021
BrokenInputStream/Reader/OutputStream/Writer #278.
@robtimus robtimus deleted the IO-729 branch September 28, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants