Add missing javadoc for exceptions thrown for invalid arguments#339
Merged
Conversation
| * @throws IOException if setting the last-modified time failed. | ||
| * @throws NullPointerException if the parameter is {@code null} | ||
| * @throws IOException if an I/O problem occurs. | ||
| * @throws IOException if setting the last-modified time failed. |
Member
There was a problem hiding this comment.
Listing each exception type once is enough IMO.
Contributor
Author
There was a problem hiding this comment.
Thanks for reviewing @garydgregory. I force pushed a new version merging the two descriptions for IOException in the same line. Does that work?
da0552d to
0f9aa35
Compare
0f9aa35 to
ab7b6ac
Compare
garydgregory
added a commit
that referenced
this pull request
Mar 28, 2022
…thrown for invalid arguments #339.
garydgregory
added a commit
that referenced
this pull request
Jan 29, 2025
Remove -nouses directive from maven-bundle-plugin. OSGi package imports now state 'uses' definitions for package imports, this doesn't affect JPMS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I added some missing javadoc for
NullPointerExceptionandIllegalArgumentExceptionin some Util classes.I added test assertions only when tests already existed for a method.
For
PathUtils.filter(PathFilter, Path... )the doc was actually inconsistent: mentioning IAE instead of NPE.Thanks for taking the time to review.