[IO-776] Fix parameters to requireNonNull call#368
Closed
cpovirk wants to merge 1 commit into
Closed
Conversation
Currently, the call checks that the literal string `"prefix"` is non-null, which of course it is :)
Contributor
Author
|
This felt small enough to get by without a JIRA ticket, but I'm happy to file one if you'd like. |
Member
|
Merged! Thanks again @cpovirk |
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
May 24, 2023
### What changes were proposed in this pull request? The pr aims to upgrade common-io from 2.11.0 to 2.12.0. ### Why are the changes needed? common-io new version includes some improvement & bug fixed, eg - apache/commons-io#450 - apache/commons-io#368 - [Add PathUtils.touch(Path)](apache/commons-io@fd7c818) The error exception of the FileUtils.touch method has been changed from `java.io.FileNotFoundException` to `java.nio.file.NoSuchFileException` - common-io 2.11.0 VS 2.12.0 apache/commons-io@rel/commons-io-2.11.0...rel/commons-io-2.12.0 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes #41271 from panbingkun/SPARK-43739. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
### What changes were proposed in this pull request? The pr aims to upgrade common-io from 2.11.0 to 2.12.0. ### Why are the changes needed? common-io new version includes some improvement & bug fixed, eg - apache/commons-io#450 - apache/commons-io#368 - [Add PathUtils.touch(Path)](apache/commons-io@fd7c818) The error exception of the FileUtils.touch method has been changed from `java.io.FileNotFoundException` to `java.nio.file.NoSuchFileException` - common-io 2.11.0 VS 2.12.0 apache/commons-io@rel/commons-io-2.11.0...rel/commons-io-2.12.0 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes apache#41271 from panbingkun/SPARK-43739. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the call checks that the literal string
"prefix"isnon-null, which of course it is :)