[IO-546] ClosedOutputStream#flush should throw#42
Closed
tjcelaya wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging an issue involving usage of
CloseShieldOutputStreamI discovered thatClosedOutputStream#flushis not overridden and will silently succeed. Not sure how much of a breaking change this might be but I think it makes more sense forClosedOutputStream#flushto throw. This is only really meaningful in contexts where multiple streams are being chained together and some of the streams beforeCloseShieldOutputStreamperform buffering, but it would make behavior more consistent for these more complex use-cases.See IO-546 where @dekobon has attached an example program.