Apply nanoseconds precision for QueueInputStream timeout duration.#453
Merged
Conversation
maxxedev
commented
Apr 23, 2023
Contributor
Also improve javadocs
kinow
reviewed
Apr 23, 2023
kinow
left a comment
Member
There was a problem hiding this comment.
Looks good to me. I couldn't see anywhere in the class telling the unit of time for the timeout. Maybe that should go in the javadoc? Thanks!
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
=========================================
Coverage 84.73% 84.73%
Complexity 3293 3293
=========================================
Files 222 222
Lines 7912 7912
Branches 948 948
=========================================
Hits 6704 6704
Misses 959 959
Partials 249 249
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
The timeout is configurable through the public API with a This PR changes so that internal usage and conversion of Duration is more precise up to nanoseconds. |
garydgregory
added a commit
that referenced
this pull request
Apr 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.