IO-811: Files.walk() direct and indirect callers fail to close the re…#489
Closed
labkey-adam wants to merge 3 commits into
Closed
IO-811: Files.walk() direct and indirect callers fail to close the re…#489labkey-adam wants to merge 3 commits into
labkey-adam wants to merge 3 commits into
Conversation
…turned Stream<Path>
garydgregory
requested changes
Sep 30, 2023
garydgregory
left a comment
Member
There was a problem hiding this comment.
Hello @labkey-adam
Thank you for your PR. I'll have to debug later but in the meantime, note the formatting nits.
asfgit
pushed a commit
that referenced
this pull request
Oct 1, 2023
internal Stream Different version of solution from PR #489 by Adam Rauch
asfgit
pushed a commit
that referenced
this pull request
Oct 1, 2023
its internal Stream Different version of solution from PR #489 by Adam Rauch
garydgregory
reviewed
Oct 1, 2023
garydgregory
left a comment
Member
There was a problem hiding this comment.
Hello @labkey-adam
Thank you for your PR. I've addressed these issues differently and credited you in changes.xml.
| */ | ||
| public static Collection<File> listFiles(final File directory, final String[] extensions, final boolean recursive) { | ||
| return Uncheck.apply(d -> toList(streamFiles(d, recursive, extensions)), directory); | ||
| return Uncheck.apply(d -> { |
Member
There was a problem hiding this comment.
I've adopted a variant of this fix in git master. You are credited in changes.xml :-)
| return iter.next(); | ||
| } | ||
| }; | ||
| }, directory); |
Member
There was a problem hiding this comment.
No need for an anonymous class:
return StreamIterator.iterator(Uncheck.get(() -> streamFiles(directory, recursive, extensions)));
Member
|
Closing, see above. Jira ticket resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…turned Stream
https://issues.apache.org/jira/browse/IO-811