[IO-781] Make CharSequenceInputStream.available() more correct in the face of multibyte encodings#525
Merged
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #525 +/- ##
============================================
- Coverage 86.31% 86.24% -0.07%
+ Complexity 3438 3437 -1
============================================
Files 229 229
Lines 8154 8159 +5
Branches 959 959
============================================
- Hits 7038 7037 -1
- Misses 834 839 +5
- Partials 282 283 +1 ☔ View full report in Codecov by Sentry. |
asfgit
pushed a commit
that referenced
this pull request
Dec 17, 2023
face of multibyte encodings #525
Member
|
@elharo TY! |
asfgit
pushed a commit
that referenced
this pull request
Dec 17, 2023
face of multibyte encodings #525
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Mar 31, 2024
### What changes were proposed in this pull request? The pr aims to upgrade `commons-io` from `2.15.1` to `2.16.0`. ### Why are the changes needed? 1.2.15.1 vs 2.16.0 apache/commons-io@rel/commons-io-2.15.1...rel/commons-io-2.16.0 2.The version fix some bugs: apache/commons-io#525 apache/commons-io#521 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45781 from panbingkun/SPARK-47656. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per contract, available() is not required to return the exact or maximum number of bytes available without blocking. It is required to return a number less than or equal to that. Always returning 0 is an acceptable implementation (though here we can do better than that).
@garydgregory
FYI locally the build fails on JDK 8 with an apparently unrelated error:
[ERROR] /Users/elharo/commons-io/src/test/java/org/apache/commons/io/file/FilesUncheckTest.java:[99,25] cannot access org.apache.commons.io.file.FilesUncheck
bad class file: /Users/elharo/commons-io/target/classes/org/apache/commons/io/file/FilesUncheck.class
undeclared type variable: A
Please remove or make sure it appears in the correct subdirectory of the classpath.
Let's see what the CI does with this.