[IO-807] Characterization test for broken symlinks when copying directories#547
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #547 +/- ##
=========================================
Coverage 85.95% 85.95%
Complexity 3480 3480
=========================================
Files 230 230
Lines 8225 8225
Branches 960 960
=========================================
Hits 7070 7070
Misses 865 865
Partials 290 290 ☔ View full report in Codecov by Sentry. |
garydgregory
reviewed
Jan 1, 2024
| final File destination = new File(tempDirFile, "destination"); | ||
| try { | ||
| FileUtils.copyDirectory(sourceDirectory, destination); | ||
| fail("ignored broken link"); |
garydgregory
requested changes
Jan 1, 2024
garydgregory
left a comment
Member
There was a problem hiding this comment.
@elharo
Thank you for your PR. Please see my comment in the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This establishes the current behavior and makes sure we don't accidentally change it.
@garydgregory