[IO-836] Update FileNameUtils Javadoc#554
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #554 +/- ##
=========================================
Coverage 85.99% 85.99%
Complexity 3492 3492
=========================================
Files 231 231
Lines 8246 8246
Branches 962 962
=========================================
Hits 7091 7091
Misses 865 865
Partials 290 290 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
garydgregory
added a commit
that referenced
this pull request
Jan 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@garydgregory I read through the entire class to to figure out its intent and I think the edits here —which are purely to doc comments, not to code — somewhat help to explain that.
Having said that, this class has some issues, including using a lot of non-standard terminology and probably some bugs on edge conditions. This will require additional PRs for code and tests.