Skip to content

[IO-836] Update FileNameUtils Javadoc#554

Merged
garydgregory merged 2 commits into
apache:masterfrom
elharo:util
Jan 6, 2024
Merged

[IO-836] Update FileNameUtils Javadoc#554
garydgregory merged 2 commits into
apache:masterfrom
elharo:util

Conversation

@elharo

@elharo elharo commented Jan 6, 2024

Copy link
Copy Markdown
Contributor

@garydgregory I read through the entire class to to figure out its intent and I think the edits here —which are purely to doc comments, not to code — somewhat help to explain that.

Having said that, this class has some issues, including using a lot of non-standard terminology and probably some bugs on edge conditions. This will require additional PRs for code and tests.

@codecov-commenter

codecov-commenter commented Jan 6, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.99%. Comparing base (511a95a) to head (448394e).
⚠️ Report is 1450 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #554   +/-   ##
=========================================
  Coverage     85.99%   85.99%           
  Complexity     3492     3492           
=========================================
  Files           231      231           
  Lines          8246     8246           
  Branches        962      962           
=========================================
  Hits           7091     7091           
  Misses          865      865           
  Partials        290      290           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elharo elharo changed the title update FileNameUtils javadoc [IO-836] update FileNameUtils javadoc Jan 6, 2024
@garydgregory garydgregory changed the title [IO-836] update FileNameUtils javadoc [IO-836] Update FileNameUtils Javadoc Jan 6, 2024
@garydgregory garydgregory merged commit 83a6d8b into apache:master Jan 6, 2024
garydgregory added a commit that referenced this pull request Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants