Make copyFile copy symbolic links by value rather than reference#565
Merged
Conversation
garydgregory
added a commit
that referenced
this pull request
Jan 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #565 +/- ##
=========================================
Coverage 85.99% 86.00%
+ Complexity 3498 3497 -1
=========================================
Files 231 231
Lines 8256 8251 -5
Branches 965 964 -1
=========================================
- Hits 7100 7096 -4
Misses 865 865
+ Partials 291 290 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the behavior of the copyFile methods in currently released versions. I'm 50/50 on whether this is what should be done if this method were new, but since i can see both sides I think backwards compatibility wins. Arguably this is the behavior that was documented for this method already, but I've tried to be more explicit about that in the doc comments.
copyDirectory is still under consideration. This PR does not change how that method currently behaves at HEAD. If we decide to do that, it can be handled in a separate PR.
@garydgregory @eamonnmcmanus