Skip to content

Update URLs and remove broken links #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garydgregory merged 2 commits into from
Jan 31, 2024
Merged

Update URLs and remove broken links #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b0fde0
update URLs and remove broken links
elharo Jan 31, 2024
f0ab9bb
link to volatile
elharo Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/main/java/org/apache/commons/io/DirectoryWalker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,11 +186,11 @@
*
* <p>
* This example provides a public {@code cancel()} method that can be called by another thread to stop the
* processing. A typical example use-case would be a cancel button on a GUI. Calling this method sets a
* <a href="https://java.sun.com/docs/books/jls/second_edition/html/classes.doc.html#36930"> volatile</a> flag to ensure
* it will work properly in a multi-threaded environment. The flag is returned by the {@code handleIsCancelled()}
* method, which will cause the walk to stop immediately. The {@code handleCancelled()} method will be the next,
* and last, callback method received once cancellation has occurred.
* processing. A typical example use-case is a cancel button on a GUI. Calling this method sets a

@garydgregory garydgregory Jan 31, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @elharo
Why not keep linking to the JLS? https://docs.oracle.com/javase/specs/jls/se8/html/jls-8.html#d5e12277

@elharo elharo Jan 31, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

* <a href='https://docs.oracle.com/javase/specs/jls/se8/html/jls-8.html#d5e12277'>(@code volatile}</a>
* flag to ensure it works properly in a multi-threaded environment.
* The flag is returned by the {@code handleIsCancelled()} method, which causes the walk to stop
* immediately. The {@code handleCancelled()} method will be the next, and last, callback method received once cancellation has occurred.
* </p>
*
* <pre>
Expand Down
9 changes: 4 additions & 5 deletions src/main/java/org/apache/commons/io/FileSystemUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,11 +473,10 @@ List<String> performCommand(final String[] cmdAttribs, final int max, final Dura
//
// This method does what it can to avoid the 'Too many open files' error
// based on trial and error and these links:
// https://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4784692
// https://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4801027
// https://forum.java.sun.com/thread.jspa?threadID=533029&messageID=2572018
// however, it's still not perfect as the JDK support is so poor
// (see commons-exec or Ant for a better multithreaded multi-OS solution)
// https://bugs.java.com/bugdatabase/view_bug.do?bug_id=4784692
// https://bugs.java.com/bugdatabase/view_bug.do?bug_id=4801027
// However, it's still not perfect as the JDK support is so poor.
// (See commons-exec or Ant for a better multithreaded multi-OS solution.)
//
final Process proc = openProcess(cmdAttribs);
final Thread monitor = ThreadMonitor.start(timeout);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/apache/commons/io/IOUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1164,7 +1164,7 @@ public static void copy(final InputStream input, final Writer writer, final Char
* </p>
* <p>
* Character encoding names can be found at
* <a href="http://www.iana.org/assignments/character-sets">IANA</a>.
* <a href="https://www.iana.org/assignments/character-sets">IANA</a>.
* </p>
* <p>
* This method uses {@link InputStreamReader}.
Expand Down