Skip to content

Fix IO-535#58

Closed
SvetlinZarev wants to merge 3 commits into
apache:masterfrom
SvetlinZarev:io-535
Closed

Fix IO-535#58
SvetlinZarev wants to merge 3 commits into
apache:masterfrom
SvetlinZarev:io-535

Conversation

@SvetlinZarev

Copy link
Copy Markdown
Contributor

Fix IO-535

Adds test case to verify the incorrect behavior and the fix.
Does not incorrectly remove the Thread.currentThread().interrupt(); like the original PR (#36 ).

Interrupt the thread created by FileAlterationMonitor on stop()
@coveralls

coveralls commented Mar 10, 2018

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.002%) to 89.717% when pulling 22ead16 on SvetlinZarev:io-535 into d08dbbf on apache:master.

@PascalSchumacher

Copy link
Copy Markdown
Contributor

Thanks! 👍

@asfgit asfgit closed this in a4705cc Apr 29, 2018
@anthonyraymond

Copy link
Copy Markdown

Wasnt this merged?

@PascalSchumacher

Copy link
Copy Markdown
Contributor

Yes it was merged in a4705cc and e9eb2d8

@anthonyraymond

Copy link
Copy Markdown

Ok. Sorry :)

@PascalSchumacher

Copy link
Copy Markdown
Contributor

No problem. Github does not show it as merged, because I squashed two commits into one and (sightly) altered the commit message. Sorry for causing this confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants