[IO-808] more precise Javadoc about when an IllegalArgumentException is thrown#581
Merged
Conversation
Member
|
Hello @elharo |
Member
|
@elharo Run |
|
see IO-778 were also IllegalArgumentException is thrown but not documented in Javadoc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify the circumstances under which an IllegalArgumentException is currently thrown. I think these are all the cases where IO-808 proposes using IOExceptions instead. This is an intermediate step that merely documents what the code currently does. Some of these should be changed. @garydgregory @sebbASF