Add classpath based lookups to FileUtils#7
Closed
agur wants to merge 1 commit into
Closed
Conversation
agur
commented
Mar 16, 2015
- Added more listFile convenience methods.
- There are additional usability improvements possible, just added a few for now.
- There are additional usability improvements possible, just added a few for now.
Author
|
Member
|
Hey @amirgur1 ! Thanks for your contribution. I have edited the issue in JIRA, but since I am not really familiar with [io] I will let others review and comment on your pull request. Thanks a lot! |
Member
There was a problem hiding this comment.
Every public method should have JavaDocs explaining the behavior.
Member
|
Please add some JUnit tests for the new functionality |
Contributor
|
This pr will require unit tests to be merged ! |
Member
|
-1 needs unit tests. See also discussion items in the Jira ticket. |
Author
Mentioned on Jira, adding tests isn't hard and agree it's needed. But also see Jira discussion and can further cont. there. To ensure we do add this if it's indeed a missing functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.