Skip to content

Add classpath based lookups to FileUtils#7

Closed
agur wants to merge 1 commit into
apache:trunkfrom
agur:trunk
Closed

Add classpath based lookups to FileUtils#7
agur wants to merge 1 commit into
apache:trunkfrom
agur:trunk

Conversation

@agur

@agur agur commented Mar 16, 2015

Copy link
Copy Markdown
  • Added more listFile convenience methods.
  • There are additional usability improvements possible, just added a few for now.

- There are additional usability improvements possible, just added a few for now.
@agur

agur commented Mar 16, 2015

Copy link
Copy Markdown
Author
  • Created a JIRA ticket IO-473 for this one per these instructions.
    Yet my commit and comment did not yet include a IO-473: prefix.
  • Yet not seeing too many pull requests. Thus will also email this to the dev list.
  • Also I can't assign IO-473 on my name for fixing. Maybe needs to be a contributor.

@kinow

kinow commented Mar 17, 2015

Copy link
Copy Markdown
Member

Hey @amirgur1 ! Thanks for your contribution. I have edited the issue in JIRA, but since I am not really familiar with [io] I will let others review and comment on your pull request. Thanks a lot!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every public method should have JavaDocs explaining the behavior.

@britter

britter commented May 22, 2015

Copy link
Copy Markdown
Member

Please add some JUnit tests for the new functionality

@krosenvold

Copy link
Copy Markdown
Contributor

This pr will require unit tests to be merged !

@asfgit asfgit closed this in 722a5af Apr 23, 2017
@garydgregory

Copy link
Copy Markdown
Member

-1 needs unit tests. See also discussion items in the Jira ticket.

@agur agur changed the title New listFile convenience methods Add classpath based lookups to FileUtils Aug 10, 2022
@agur

agur commented Aug 10, 2022

Copy link
Copy Markdown
Author

-1 needs unit tests. See also discussion items in the Jira ticket.

Mentioned on Jira, adding tests isn't hard and agree it's needed. But also see Jira discussion and can further cont. there. To ensure we do add this if it's indeed a missing functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants