[IO-875] CopyDirectoryVisitor ignores fileFilter #743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pbaumard
commented
May 4, 2025
•
- Fix IO-875
- Fix javadoc
- Added assertions for the copied files and to get a 100% coverage
garydgregory
requested changes
May 4, 2025
I thought at first that those removed assertions were useless since they were flagged by SonarLint (RSPEC-5845 and RSPEC-5863). |
garydgregory
added a commit
that referenced
this pull request
May 5, 2025
- Document adding and using org.apache.commons.io.file.CountingPathVisitor.accept(Path, BasicFileAttributes) #743 - Added missing Javadoc since tag - Fix Javadoc comment - Remove extra blank lines - Sort members
|
Thank you for your updates. I merged this PR followed up by some cleanups in git master. TY! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.