Fix interface discovery in CloseShieldChannel#800
Merged
garydgregory merged 1 commit intomasterfrom Oct 14, 2025
Merged
Conversation
This PR is split from #799. The `CloseShieldChannel` implementation only inspects interfaces **directly** implemented by the given channel’s class, ignoring those inherited from its superclasses. As a result, proxies for types such as `FileChannel` does not expose any of the interfaces declared on `FileChannel` itself.
garydgregory
approved these changes
Oct 14, 2025
Member
garydgregory
left a comment
There was a problem hiding this comment.
LGTM! Thank you @ppkarwasz
CloseShieldChannelCloseShieldChannel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is split from #799.
The
CloseShieldChannelimplementation only inspects interfaces directly implemented by the given channel’s class, ignoring those inherited from its superclasses. As a result, proxies for types such asFileChanneldoes not expose any of the interfaces declared onFileChannelitself.