[LANG-1786] Cache short ids and log once

[garydgregory]

[LANG-1786] A lot of warnings on the console when using FastDateFormat
with JDK25

Add and use TimeZones.getTimeZone(String) as a way to avoid writing to the console on Java 25:

    /**
     * Delegates to {@link TimeZone#getTimeZone(String)} with special behavior on Java 25.
     * <p>
     * On Java 25, this methods delegates once to {@link TimeZone#getTimeZone(String)} for each short ID to avoid logging deprecation warning to system error.
     * </p>
     * <p>
     * On Java 25, this message is of the form:
     * </p>
     *
     * <pre>
     * WARNING: Use of the three-letter time zone ID "the-short-id" is deprecated and it will be removed in a future release
     * </pre>
     *
     * @param id Same as {@link TimeZone#getTimeZone(String)}.
     * @return Same as {@link TimeZone#getTimeZone(String)}.
     * @since 3.20.0
     */
    public static synchronized TimeZone getTimeZone(final String id) {

Before you push a pull request, review this list:

• Read the contribution guidelines for this project.
• Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
• I used AI to create any part of, or all of, this pull request.
• Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
• Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

[LI123456mo]

Hi everyone
It is my first time to join here , Just new and am looking foward to learn new things here and also offer some help

[lprimak]

Looking at this, it introduces a synchronized method for the timezone. Does this have negative overall performance implications?
The cache is a concurrent map, so maybe this can be avoided?

[garydgregory]

Looking at this, it introduces a synchronized method for the timezone. Does this have negative overall performance implications? The cache is a concurrent map, so maybe this can be avoided?

I removed the synchronized on the method.

[LI123456mo]

Okay , I want to contribute there but the only thing I atleast know is java dsa, am currently on linkedlist,have already learn Oops , so is there any guidance you can give me on this

…

________________________________ From: Gary Gregory ***@***.***> Sent: Thursday, November 6, 2025 8:46 PM To: apache/commons-lang ***@***.***> Cc: conellimo ***@***.***>; Comment ***@***.***> Subject: Re: [apache/commons-lang] [LANG-1786] Cache short ids and log once (PR #1482) [https://avatars.githubusercontent.com/u/1187639?s=20&v=4]garydgregory left a comment (apache/commons-lang#1482)<#1482 (comment)> Looking at this, it introduces a synchronized method for the timezone. Does this have negative overall performance implications? The cache is a concurrent map, so maybe this can be avoided? I removed the synchronized on the method. — Reply to this email directly, view it on GitHub<#1482 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BTNBOCFW2WDLOJ7SFBL6X5L33OCQ3AVCNFSM6AAAAACLIUEL36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIOJYGU4TINJZGA>. You are receiving this because you commented.Message ID: ***@***.***>