Skip to content

Use UTC in generating DOS date#15

Merged
ctalkington merged 1 commit into
archiverjs:masterfrom
joelmukuthu:master
Mar 25, 2015
Merged

Use UTC in generating DOS date#15
ctalkington merged 1 commit into
archiverjs:masterfrom
joelmukuthu:master

Conversation

@joelmukuthu

Copy link
Copy Markdown
Contributor

Closes #14

@joelmukuthu

Copy link
Copy Markdown
Contributor Author

Any word on this? This fix is quite critical, especially for tests. If you're running tests to verify that the created archive is exactly the same as an archive that you have created manually, and you happen to run the test on a machine whose timezone is not the same as your machine's timezone (e.g. on a CI platform), then the test will fail. This happens because the last-modified time of the entries in the archive are different.
Since DOS time does not have timezone information, you should use universal time for the entries.

@ctalkington

Copy link
Copy Markdown
Member

ive went back and forth on this in the past used to patch my tests to account for such too. hum let me think on this for a bit longer; i do see merit in it... lets just do it now :)

ctalkington added a commit that referenced this pull request Mar 25, 2015
Use UTC in generating DOS date
@ctalkington ctalkington merged commit 359aad3 into archiverjs:master Mar 25, 2015
@joelmukuthu

Copy link
Copy Markdown
Contributor Author

great, thanks! any plans of an upcoming release?

@ctalkington

Copy link
Copy Markdown
Member

yep, just got sidetracked

@joelmukuthu

Copy link
Copy Markdown
Contributor Author

perfect! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use UTC in generating DOS date

2 participants