Added new functionality to allow users to send content to be diffed as p...#6
Conversation
|
Excellent feature, thanks @shikher. Can I request you to make a couple of changes in this PR:
I'll merge as soon as I hear back on #1. |
|
Also, if you really want to make this even better, add a jsfiddle (you can fork the one we have here and demo your feature there. |
|
Sure, I will make both the changes and add a link to the jsfiddle. Where On Mon, Aug 25, 2014 at 11:03 AM, Arnab Deka notifications@github.com
|
|
Cool. You can add the link in the demo section in the README. |
|
Sounds good. On Mon, Aug 25, 2014 at 11:12 AM, Arnab Deka notifications@github.com
|
01222bc to
13d0985
Compare
|
I have updated the pull request. Please look at the commit and let me know if any more changes are required. |
…s parameters to the 'prettyTextDiff' function. Currently, the user has to set th text of the HTML elements i.e. the originalContainer and the changedContainer. This required the HTML content of the two containers to be part of the page source which caused web pages to be prone to XSS attacks. This method allows the user to set the HTML content to a JS variable and pass it as a parameter to this function. Both functionalities are supported to not break the existing plugin.
6d46f81 to
5432e70
Compare
Added new functionality to allow users to send content to be diffed as p...
...arameters to the 'prettyTextDiff' function.
Currently, the user has to set th text of the HTML elements i.e. the originalContainer and the changedContainer. This required the HTML content of the two containers to be part of the page source which caused web pages to be prone to XSS attacks. This method allows the user to set the HTML content to a JS variable and pass it as a parameter to this function. Both functionalities are supported to not break the existing plugin.