Skip to content

Added new functionality to allow users to send content to be diffed as p...#6

Merged
arnab merged 1 commit intoarnab:masterfrom
LMcule:handle_unsafe_data
Aug 26, 2014
Merged

Added new functionality to allow users to send content to be diffed as p...#6
arnab merged 1 commit intoarnab:masterfrom
LMcule:handle_unsafe_data

Conversation

@LMcule
Copy link
Contributor

@LMcule LMcule commented Aug 21, 2014

...arameters to the 'prettyTextDiff' function.

Currently, the user has to set th text of the HTML elements i.e. the originalContainer and the changedContainer. This required the HTML content of the two containers to be part of the page source which caused web pages to be prone to XSS attacks. This method allows the user to set the HTML content to a JS variable and pass it as a parameter to this function. Both functionalities are supported to not break the existing plugin.

@arnab
Copy link
Owner

arnab commented Aug 25, 2014

Excellent feature, thanks @shikher. Can I request you to make a couple of changes in this PR:

  1. Please document your new feature in the README's options section.
  2. Optionally, feel free to remove the js and minified js from your PR - I will generate those and push to jQuery plugins.

I'll merge as soon as I hear back on #1.

@arnab
Copy link
Owner

arnab commented Aug 25, 2014

Also, if you really want to make this even better, add a jsfiddle (you can fork the one we have here and demo your feature there.

@LMcule
Copy link
Contributor Author

LMcule commented Aug 25, 2014

Sure, I will make both the changes and add a link to the jsfiddle. Where
should I mention the link to the jsfiddle?

On Mon, Aug 25, 2014 at 11:03 AM, Arnab Deka notifications@github.com
wrote:

Also, if you really want to make this even better, add a jsfiddle (you can
fork the one we have here http://jsfiddle.net/YwSVY/ and demo your
feature there.


Reply to this email directly or view it on GitHub
#6 (comment)
.

@arnab
Copy link
Owner

arnab commented Aug 25, 2014

Cool. You can add the link in the demo section in the README.

@LMcule
Copy link
Contributor Author

LMcule commented Aug 25, 2014

Sounds good.

On Mon, Aug 25, 2014 at 11:12 AM, Arnab Deka notifications@github.com
wrote:

Cool. You can add the link in the demo section in the README.


Reply to this email directly or view it on GitHub
#6 (comment)
.

@LMcule LMcule force-pushed the handle_unsafe_data branch from 01222bc to 13d0985 Compare August 25, 2014 22:29
@LMcule
Copy link
Contributor Author

LMcule commented Aug 25, 2014

I have updated the pull request. Please look at the commit and let me know if any more changes are required.

…s parameters to the 'prettyTextDiff' function.

Currently, the user has to set th text of the HTML elements i.e. the originalContainer and the changedContainer. This required the HTML content of the two containers to be part of the page source which caused web pages to be prone to XSS attacks. This method allows the user to set the HTML content to a JS variable and pass it as a parameter to this function. Both functionalities are supported to not break the existing plugin.
@LMcule LMcule force-pushed the handle_unsafe_data branch from 6d46f81 to 5432e70 Compare August 25, 2014 22:35
arnab added a commit that referenced this pull request Aug 26, 2014
Added new functionality to allow users to send content to be diffed as p...
@arnab arnab merged commit 142ffb4 into arnab:master Aug 26, 2014
arnab added a commit that referenced this pull request Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants