New massive update#8
Closed
indrimuska wants to merge 7 commits intoarschmitz:masterfrom
indrimuska:master
Closed
Conversation
Contributor
indrimuska
commented
Jan 28, 2014
- folder structure for jqm 1.4 (just moved files)
- demo updated
- support for [data-theme] attribute
- etc..
Added padding and min-width for unselectables days
Added author section
Previous code doesn’t allow to set a custom callback for onSelect/onChangeMonth/beforeShow and either restyle the calendar
Closed
Owner
|
sorry it took me a while to get to this this still has many issues i would really like to make most of these changes but i just cant land this for reasons i listed in the last pull request. I think it would be much more beneficial if you took this on a per issue basis and did one pull request for each it will make it easier to review and much more likely to get these fixes landed. I appreciate all your effort and hope doing each issue in a separate PR will be acceptable |
Contributor
Author
|
ok, i'll open other new pull request for each new update i've done. |
Owner
|
Thank you i'm looking forward to the updates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.