Fix commons-app#2134: Remove formatting characters from upload_problem strings (commons-app#2135)

Author: cypherop

app/src/main/java/fr/free/nrw/commons/utils/ImageUtils.java

@@ -236,22 +236,22 @@ public static String getErrorMessageForResult(Context context, @Result int resul
             errorMessage.append(context.getResources().getString(R.string.upload_problem_exist));
 
             if ((IMAGE_DARK & result) != 0 ) { // We are checking image dark bit to see if that bit is set or not
-                errorMessage.append(context.getResources().getString(R.string.upload_problem_image_dark));
+                errorMessage.append("\n - ").append(context.getResources().getString(R.string.upload_problem_image_dark));
             }
 
             if ((IMAGE_BLURRY & result) != 0 ) {
-                errorMessage.append(context.getResources().getString(R.string.upload_image_problem_blurry));
+                errorMessage.append("\n - ").append(context.getResources().getString(R.string.upload_image_problem_blurry));
             }
 
             if ((IMAGE_DUPLICATE & result) != 0 ) {
-                errorMessage.append(context.getResources().getString(R.string.upload_problem_image_duplicate));
+                errorMessage.append("\n - ").append(context.getResources().getString(R.string.upload_problem_image_duplicate));
             }
 
             if ((IMAGE_GEOLOCATION_DIFFERENT & result) != 0 ) {
-                errorMessage.append(context.getResources().getString(R.string.upload_problem_different_geolocation));
+                errorMessage.append("\n - ").append(context.getResources().getString(R.string.upload_problem_different_geolocation));
             }
 
-            errorMessage.append(context.getResources().getString(R.string.upload_problem_do_you_continue));
+            errorMessage.append("\n\n").append(context.getResources().getString(R.string.upload_problem_do_you_continue));
         }
 
         return errorMessage.toString();

app/src/main/res/values/strings.xml

@@ -237,11 +237,11 @@
   <string name="upload_image_blurry">This picture is blurry, are you sure you want to upload it? Wikimedia Commons is only for pictures with encyclopedic value.</string>
 
   <string name="upload_problem_exist">Potential problems with this image:</string>
-  <string name="upload_problem_image_dark">\n - Image is too dark.</string>
-  <string name="upload_problem_image_blurry">\n - Image is blurry.</string>
-  <string name="upload_problem_image_duplicate">\n - Image is already on Commons.</string>
-  <string name="upload_problem_different_geolocation">\n - This picture was taken at a different location.</string>
-  <string name="upload_problem_do_you_continue">\n\nDo you still want to upload this picture?</string>
+  <string name="upload_problem_image_dark">Image is too dark.</string>
+  <string name="upload_problem_image_blurry">Image is blurry.</string>
+  <string name="upload_problem_image_duplicate">Image is already on Commons.</string>
+  <string name="upload_problem_different_geolocation">This picture was taken at a different location.</string>
+  <string name="upload_problem_do_you_continue">Do you still want to upload this picture?</string>
 
   <string name="give_permission">Give permission</string>
   <string name="use_external_storage">Use external storage</string>