Skip to content

Removed formatting characters from upload_problem strings(#2134) #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

cypherop
Copy link
Contributor

Fixes #2134 Removed formatting characters from upload_problem strings

What changes did you make and why?
Removed "\n - " from upload_problem strings added in #2099 as it will confuse translators and not really part of the string.

@codecov-io
Copy link

Codecov Report

Merging #2135 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2135   +/-   ##
======================================
  Coverage    5.52%   5.52%           
======================================
  Files         234     234           
  Lines       11596   11596           
  Branches     1079    1079           
======================================
  Hits          641     641           
  Misses      10902   10902           
  Partials       53      53
Impacted Files Coverage Δ
...ain/java/fr/free/nrw/commons/utils/ImageUtils.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09ce41...56c0339. Read the comment docs.

@domdomegg domdomegg self-requested a review December 16, 2018 20:05
@domdomegg
Copy link
Member

Tested 2.9.0-debug-pr-2135~56c03395 on Galaxy Nexus (emulator) at API Level 28.

@domdomegg domdomegg merged commit 102b2d7 into commons-app:master Dec 17, 2018
@cypherop cypherop deleted the fix#2134 branch December 20, 2018 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants