A generalised message for exceptions in Nearby Activity [issue commons-app#1504]

Author: ashishkumar468

app/src/main/java/fr/free/nrw/commons/nearby/NearbyActivity.java

@@ -435,11 +435,8 @@ private void refreshView(LocationServiceManager.LocationChangeType locationChang
                     .observeOn(AndroidSchedulers.mainThread())
                     .subscribe(this::populatePlaces,
                             throwable -> {
-                                if (throwable instanceof UnknownHostException || throwable instanceof ConnectException) {
-                                    showErrorMessage(getString(R.string.slow_internet));
-                                } else {
-                                    showErrorMessage(throwable.getMessage());
-                                }
+                                Timber.d(throwable);
+                                showErrorMessage(getString(R.string.error_fetching_nearby_places));
                                 progressBar.setVisibility(View.GONE);
                             });
         } else if (locationChangeType
@@ -597,11 +594,8 @@ private void updateMapFragment(boolean isSlightUpdate) {
                         .observeOn(AndroidSchedulers.mainThread())
                         .subscribe(this::populatePlaces,
                                 throwable -> {
-                                    if (throwable instanceof UnknownHostException || throwable instanceof ConnectException) {
-                                        showErrorMessage(getString(R.string.slow_internet));
-                                    } else {
-                                        showErrorMessage(throwable.getMessage());
-                                    }
+                                    Timber.d(throwable);
+                                    showErrorMessage(getString(R.string.error_fetching_nearby_places));
                                     progressBar.setVisibility(View.GONE);
                                 });
                 nearbyMapFragment.setBundleForUpdtes(bundle);
@@ -671,9 +665,6 @@ public void prepareViewsForSheetPosition(int bottomSheetState) {
     }
 
     private void showErrorMessage(String message) {
-        if (TextUtils.isEmpty(message)) {
-            message = getString(R.string.something_went_wrong);
-        }
         ViewUtil.showLongToast(NearbyActivity.this, message);
     }
 }

app/src/main/res/values/strings.xml

@@ -282,7 +282,6 @@
 
   <string name="share_app_title">Share App</string>
   <string name="share_coordinates_not_present">Coordinates were not specified during image selection</string>
-  <string name="something_went_wrong">Something went wrong</string>
-  <string name="slow_internet">You seem to have slow internet connection</string>
+  <string name="error_fetching_nearby_places">Error fetching nearby places.</string>
 
 </resources>