App crashes when opening *Nearby* in a particular scenario

[sivaraam]

Summary:
Nearby crashes when the phone is connected to a network that is disconnected from the ISP's network. To be more detailed, I use a Wi-Fi enabled data modem with the ability to disconnect the data service. So, when I disconnect the data service and connect the phone to the Wi-Fi network (which isn't connected to the ISP's network) and visit Nearby, the app crashes.

Steps to reproduce:

1. Connect to a network that isn't connected to the ISP's network in some way (one way is described in the summary)
2. Open the app
3. Open Nearby

Add System logs:

D/NearbyPlaces: java.net.ConnectException: failed to connect to query.wikidata.org/192.168.206.84 (port 443): connect failed: ECONNREFUSED (Connection refused)
D/NearbyPlaces: back to initial radius: 1.000000
W/System.err: io.reactivex.exceptions.OnErrorNotImplementedException: Callable returned null
W/System.err:     at io.reactivex.internal.functions.Functions$OnErrorMissingConsumer.accept(Functions.java:704)
W/System.err:     at io.reactivex.internal.functions.Functions$OnErrorMissingConsumer.accept(Functions.java:701)
W/System.err:     at io.reactivex.internal.observers.LambdaObserver.onError(LambdaObserver.java:74)
W/System.err:     at io.reactivex.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.checkTerminated(ObservableObserveOn.java:276)
W/System.err:     at io.reactivex.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.drainNormal(ObservableObserveOn.java:172)
W/System.err:     at io.reactivex.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.run(ObservableObserveOn.java:252)
W/System.err:     at io.reactivex.android.schedulers.HandlerScheduler$ScheduledRunnable.run(HandlerScheduler.java:109)
W/System.err:     at android.os.Handler.handleCallback(Handler.java:739)
W/System.err:     at android.os.Handler.dispatchMessage(Handler.java:95)
W/System.err:     at android.os.Looper.loop(Looper.java:145)
W/System.err:     at android.app.ActivityThread.main(ActivityThread.java:6946)
W/System.err:     at java.lang.reflect.Method.invoke(Native Method)
W/System.err:     at java.lang.reflect.Method.invoke(Method.java:372)
W/System.err:     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1404)
W/System.err:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1199)
W/System.err: Caused by: java.lang.NullPointerException: Callable returned null
W/System.err:     at io.reactivex.internal.functions.ObjectHelper.requireNonNull(ObjectHelper.java:39)
W/System.err:     at io.reactivex.internal.operators.observable.ObservableFromCallable.subscribeActual(ObservableFromCallable.java:42)
W/System.err:     at io.reactivex.Observable.subscribe(Observable.java:10901)
W/System.err:     at io.reactivex.internal.operators.observable.ObservableSubscribeOn$SubscribeTask.run(ObservableSubscribeOn.java:96)
W/System.err:     at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:452)
W/System.err:     at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:61)
W/System.err:     at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:52)
W/System.err:     at java.util.concurrent.FutureTask.run(FutureTask.java:237)
W/System.err:     at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:152)
W/System.err:     at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:265)
W/System.err:     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
W/System.err:     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
W/System.err:     at java.lang.Thread.run(Thread.java:818)
E/AndroidRuntime: FATAL EXCEPTION: main
                  Process: fr.free.nrw.commons.debug, PID: 16239
                  io.reactivex.exceptions.OnErrorNotImplementedException: Callable returned null
...
I/Process: Sending signal. PID: 16239 SIG: 9

Expected behavior:
Warn about the inability to connect to the network.

Observed behavior:
The app crashes.

Device and Android version:
Device: Samsung Galaxy J2
Android: 5.1.1

Commons app version:
2.7.1

Would you like to work on the issue?
Nope, sorry ☺️

[misaochan]

Is it Android Studio that isn't working for you, or manual builds? AFAIK you can get logs via Android Studio's logcat without building - if you download the Play Store version and hook it up to your computer, it should still display logs (although filtering them might work differently).

We have a "Send logs" feature, but that really needs to be fixed as it hasn't given us anything useful ever. :/ There is a separate issue for that.

[sivaraam]

Is it Android Studio that isn't working for you, or manual builds? ? AFAIK you can get logs via Android Studio's logcat without building ...

Actually Android studio required the Gradle build for the modified source (not the apk generation) to be completed before the dubug console could be used to debug the hooked up to the device.

[ashishkumar468]

I tried to reproduce the issue and made the app crash with the following logs

io.reactivex.exceptions.OnErrorNotImplementedException: Callable returned null
        at io.reactivex.internal.functions.Functions$OnErrorMissingConsumer.accept(Functions.java:704)
        at io.reactivex.internal.functions.Functions$OnErrorMissingConsumer.accept(Functions.java:701)
        at io.reactivex.internal.observers.LambdaObserver.onError(LambdaObserver.java:74)
        at io.reactivex.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.checkTerminated(ObservableObserveOn.java:276)
        at io.reactivex.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.drainNormal(ObservableObserveOn.java:172)
        at io.reactivex.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.run(ObservableObserveOn.java:252)
        at io.reactivex.android.schedulers.HandlerScheduler$ScheduledRunnable.run(HandlerScheduler.java:109)
        at android.os.Handler.handleCallback(Handler.java:739)
        at android.os.Handler.dispatchMessage(Handler.java:95)
        at android.os.Looper.loop(Looper.java:135)
        at android.app.ActivityThread.main(ActivityThread.java:5254)
        at java.lang.reflect.Method.invoke(Native Method)
        at java.lang.reflect.Method.invoke(Method.java:372)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
     Caused by: java.lang.NullPointerException: Callable returned null
        at io.reactivex.internal.functions.ObjectHelper.requireNonNull(ObjectHelper.java:39)
        at io.reactivex.internal.operators.observable.ObservableFromCallable.subscribeActual(ObservableFromCallable.java:42)
        at io.reactivex.Observable.subscribe(Observable.java:10901)
        at io.reactivex.internal.operators.observable.ObservableSubscribeOn$SubscribeTask.run(ObservableSubscribeOn.java:96)
        at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:452)
        at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:61)
        at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:52)
        at java.util.concurrent.FutureTask.run(FutureTask.java:237)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:152)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:265)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
        at java.lang.Thread.run(Thread.java:818)

[maskaravivek]

Looks like null isn't handled properly while loading data in nearby. @ashishkumar468 will you be able to take care of this issue?

[ashishkumar468]

@maskaravivek I have most probably made the fix, creating a pull request for the same

[sivaraam]

Thanks @ashishkumar468 for your thoughts.

Actually Android studio required the Gradle build for the modified source (not the apk generation) to be completed before the dubug console could be used to debug the hooked up to the device.

Sorry, that seems to be a misleading comment. I actually was overlooked and mistook the "debug build" icon for the "attach debugger" icon 😞

Regardless, I wasn't able to able to attach the debugger to a production release.

[sivaraam]

OK. Things are getting worser. I'm note even able to login into my account! This is on the app built from d960029 installed through the debug build. I get the following in logcat:

D/ViewRootImpl: ViewPostImeInputStage ACTION_DOWN
D/ViewRootImpl: ViewPostImeInputStage ACTION_DOWN
D/LoginActivity: Login to start!
D/TextView: setTypeface with style : 0
D/PhoneWindow: *FMB* installDecor mIsFloating : true
D/PhoneWindow: *FMB* installDecor flags : 8388610
D/TextView: setTypeface with style : 0
D/TextView: setTypeface with style : 0
D/TextView: setTypeface with style : 0
D/TextView: setTypeface with style : 0
D/ViewRootImpl: Buffer Count from app info with  ::-1 && -1 for :: fr.free.nrw.commons.debug from View :: -1 DBQ Enabled ::false false
I/System.out: Thread-2887(ApacheHTTPLog):isSBSettingEnabled false
I/System.out: Thread-2887(ApacheHTTPLog):isShipBuild true
I/System.out: Thread-2887(ApacheHTTPLog):SMARTBONDING_ENABLED is false
I/System.out: Thread-2887(ApacheHTTPLog):SmartBonding Enabling is false, SHIP_BUILD is true, log to file is false, DBG is false
D/PhoneWindow: *FMB* isFloatingMenuEnabled mFloatingMenuBtn : null
D/PhoneWindow: *FMB* isFloatingMenuEnabled return false
D/mali_winsys: new_window_surface returns 0x3000,  [597x338]-format:1
I/System.out: RxCachedThreadScheduler-2 calls detatch()
D/ApacheHttpClientMediaWi: Login token is <LOGIN_TOKEN_STRIPPED>+\
I/System.out: Thread-2887(ApacheHTTPLog):isSBSettingEnabled false
I/System.out: Thread-2887(ApacheHTTPLog):isShipBuild true
I/System.out: Thread-2887(ApacheHTTPLog):SMARTBONDING_ENABLED is false
I/System.out: Thread-2887(ApacheHTTPLog):SmartBonding Enabling is false, SHIP_BUILD is true, log to file is false, DBG is false
I/System.out: RxCachedThreadScheduler-2 calls detatch()
D/LoginActivity: Login done!
E/ViewRootImpl: sendUserActionEvent() mView == null

The screenshot of the app in that case:

But, I'm 100% sure I used the right password. I was able to successfully log-in using that password in my browser, just now.

[ashishkumar468]

@sivaraam This seems to be a different issue, anybody else if facing such issues ?

[sivaraam]

@ashishkumar468 Yep. It does seem to be different issue. I forgot to mention that "I just wanted to be sure I'm not the only one facing this".

So, am I missing something?

[ashishkumar468]

@sivaraam You are trying to login into betaDebug build variant I suppose, make sure that you signed up on the same variant or try to login with the same credentials in prodDebug or prodRelease build variant

[sivaraam]

@ashishkumar468 Thanks for the pointer!

Regardless of that, I guess the error message could be made more helpful/useful as it mentioned only about checking my password and not my username!

[ashishkumar468]

@sivaraam Sure, Thanks for the suggestion, you can create a new issue for that and someone can pick that up as an enhancement, coming back to this issue, were you able to login ?